Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generatedAnswer): map state with answerAPI #4684

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

dmgauthier
Copy link
Contributor

SVCC-4353
https://coveord.atlassian.net/browse/SVCC-4353

See #4681 for the V3 PR. 🍝 Copy pasta of the description 👇

The problem

Upon interacting with a stream response, all headless selectors relying on the generatedAnswer slice after a response fetched by the answerAPI client aren't working properly because the state of the answerAPI client is not mapped to the actual generatedAnswer slice.
e.g. the custom events

The proposed fix

The answer API client is now dispatching what is relevant to the generatedAnswer state. The selectors will then return the same value as the generated answer controller state whenever it gets its answer from the client getting its answer directly from reveal or from the answer api.

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.5 248.7 1.7
commerce 343.2 347.4 1.2
search 417.5 417.6 0
insight 395.3 395.4 0
product-listing 306.9 311.1 1.4
product-recommendation 215.3 221.4 2.8
recommendation 257.7 261.9 1.6
ssr 407.9 408 0
ssr-commerce 353.8 358 1.2

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@dmgauthier dmgauthier force-pushed the fix-SVCC-4353-v2-generated-answer-state-mapping branch from 989434c to 4a3cb09 Compare November 19, 2024 16:12
@dmgauthier dmgauthier added this pull request to the merge queue Nov 19, 2024
Merged via the queue into v2 with commit d0efeb8 Nov 19, 2024
115 checks passed
@dmgauthier dmgauthier deleted the fix-SVCC-4353-v2-generated-answer-state-mapping branch November 19, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants