Adapt atomic-facet-manager to acquire facets nested within atomic-popover #6678
+132
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
atomic-facet-managerwas unable to discover and manage facets nested insideatomic-popoverelements becausegetFacetsInChildren()only checked direct children.Changes:
isPopover()helper to detectatomic-popoverelementsgetFacetsInChildren()in bothstencil-facet-common.tsxandfacet-common.tsto look inside popover childrenatomic-facet-managerwith facets insideatomic-popoverUsage example:
Note: Uses
find()rather thanfilter()sinceatomic-popoverenforces a single child facet by design.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.