You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the LLVM install script (for Debian Linux OS) cannot be used more than once in a single workflow run. This means users will have an error if
runs-on: ubuntu-lateststeps:
- uses: cpp-linter/cpp-linter-action@v2with:
version: 16# re-run action in same workflow with different clang version
- uses: cpp-linter/cpp-linter-action@v2with:
# ERROR: the LLVM PPA repo is already set to use v16 from previous stepversion: 19
The error would look something like:
E: The repository 'http://apt.llvm.org/jammy llvm-toolchain-jammy-16 Release' does not have a Release file.
I solved this problem (in experiments) by removing the LLVM PPA repo after we install clang-tidy and clang-format from it:
I did consider adding the LLVM apt PPA repo manually. However, the install script takes care of a lot of other cross-distribution problems, namely determining which derivative/flavor of Debian is used. Using the install script still relieves some tech debt as it is well maintained by the LLVM project.
The scenario in which cpp-linter-action might be used more than once in a single workflow depends on the project being analyzed. As an example, a user might want to examine different sources using different compilation databases. Ultimately, the cpp-linter python package is not well suited for multiple uses in a single CI event, but that is an issue (or multitude of issues) for another time.
In the case where a user's workflow might expect the LLVM apt PPA repo to still be employed (after running cpp-linter-action), it might be a good idea to have a new input option to prevent the removal of the LLVM apt PPA repo. I suspect this to be a rare use case though.
The text was updated successfully, but these errors were encountered:
resolves#265
Users that expect the PPA to be present _after_ running cpp-linter-action can set the environment variable `KEEP_DEBIAN_LLVM_PPA` to `true`, `on`, or `1`. By default, the PPA is removed.
resolves#265
Users that expect the PPA to be present _after_ running cpp-linter-action can set the environment variable `KEEP_DEBIAN_LLVM_PPA` to `true`, `on`, or `1`. By default, the PPA is removed.
Is your idea related to an existing feature?
version
Describe the behavior you would like
I noticed that the LLVM install script (for Debian Linux OS) cannot be used more than once in a single workflow run. This means users will have an error if
The error would look something like:
I solved this problem (in experiments) by removing the LLVM PPA repo after we install clang-tidy and clang-format from it:
Describe alternatives you have considered
I did consider adding the LLVM apt PPA repo manually. However, the install script takes care of a lot of other cross-distribution problems, namely determining which derivative/flavor of Debian is used. Using the install script still relieves some tech debt as it is well maintained by the LLVM project.
Additional context
The updated source of the LLVM install script can be examined from https://apt.llvm.org/llvm.sh.
The scenario in which cpp-linter-action might be used more than once in a single workflow depends on the project being analyzed. As an example, a user might want to examine different sources using different compilation databases. Ultimately, the cpp-linter python package is not well suited for multiple uses in a single CI event, but that is an issue (or multitude of issues) for another time.
In the case where a user's workflow might expect the LLVM apt PPA repo to still be employed (after running cpp-linter-action), it might be a good idea to have a new input option to prevent the removal of the LLVM apt PPA repo. I suspect this to be a rare use case though.
The text was updated successfully, but these errors were encountered: