-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tidy-review
and format-review
for draft PRs
#270
Comments
This was intentional. The tidy-review feature is still a bit experimental from our end. And, I would say you missed this if you didn't read our documented PR review caveats. This actually marks the second request to allow drafted PRs to be reviewed by cpp-linter. Maybe I should expose this capability via an env var ( I'd be more confident in these features if I could devise a way to reduce duplicate suggestions... |
True, sorry for that. I only searched in Inputs and Outputs for "draft". And thanks for your quick answer. I guess it might be enough for the time being to look at the Feel free to close this feature request or keep it open for others as reference. |
I'll close it as "unplanned" and pin it for visibility. People that want this feature can add a 👍. This thread will not be locked either, so anyone with additional context can post it here. |
Is your idea related to an existing feature?
tidy-review, format-review
Describe the behavior you would like
Perhaps I missed somethings but it looks like
tidy-review
andformat-review
are not supported in draft PRs. At least, there are no code reviews available in a draft PR even with the features enabled.We are using drafts a lot for early reviews and the other obvious reasons, so it would be good to be able to incorporate the suggested changes already at that stage.
Describe alternatives you have considered
No response
Additional context
Otherwise, it's really good action. Thanks for the effort!
The text was updated successfully, but these errors were encountered: