Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimal way of making Xembler work with Report is not obvious #322

Closed
gsnoff opened this issue Apr 23, 2019 · 7 comments
Closed

Optimal way of making Xembler work with Report is not obvious #322

gsnoff opened this issue Apr 23, 2019 · 7 comments

Comments

@gsnoff
Copy link
Contributor

gsnoff commented Apr 23, 2019

As per #227:

Refactor towards a simpler solution that ideally would just require one or two Xembly instructions add the required attribute.

The problem with using Xembly here is summed up by the following (see #196 (comment)):

Xembler works with nodes. Can't set the required attribute on the node returned by the XML resulting from transforming the skeleton into metric because it's a document node (throws error "Cannot cast ...DocumentImpl to ...Element").

Because it is not obvious what would a better solution look like exactly, I think this separate issue is needed so that the scope of #227 itself wouldn’t go beyond 30 minutes. We probably need to make a design decision here first.

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2019

@paulodamaso/z please, pay attention to this issue

@gsnoff
Copy link
Contributor Author

gsnoff commented Apr 23, 2019

/cc @yegor256 @llorllale

@gsnoff
Copy link
Contributor Author

gsnoff commented Apr 27, 2019

@yegor256 @paulodamaso @llorllale Apparently there is a possible (relatively) clean solution. What was really needed here is to point the cursor to the metric element via an XPATH instruction first.

See #325 #326

@llorllale
Copy link
Contributor

@Protagores I see that you've successfully managed to add the attribute with Xembly; what I don't understand is how this is any less "weird" (as per Yegor) than simply making use of the existing XSLChain.

I'll let @yegor256 decide.

@gsnoff
Copy link
Contributor Author

gsnoff commented May 2, 2019

@paulodamaso Proposed solution already accepted and merged. Closing this.

@gsnoff gsnoff closed this as completed May 2, 2019
@0crat
Copy link
Collaborator

0crat commented May 2, 2019

Job gh:yegor256/jpeek#322 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented May 2, 2019

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants