-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#481 - Pass metric name via constructor. #485
Conversation
@paulodamaso Can you check why no reviewer has been assigned? |
@0crat in |
@paulodamaso Job #485 is already in scope |
@0crat status |
@paulodamaso This is what I know about this job in C7JGJ00DP, as in §32: |
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
There is an unrecoverable failure on my side. Please, submit it here:
|
There is an unrecoverable failure on my side. Please, submit it here:
|
@paulodamaso @vzurauskas Oops, I failed. You can see the full log here (spent 16s)
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso @vzurauskas Oops, I failed. You can see the full log here (spent 16s)
|
@yegor256 could you please fix this? Seems that renaming the repo messed with some asset permissions in |
@@ -171,123 +170,122 @@ public void analyze() throws IOException { | |||
final XSL chain = new XSLChain(layers); | |||
this.save(skeleton.toString(), "skeleton.xml"); | |||
final Collection<Report> reports = new LinkedList<>(); | |||
final Calculus xsl = new XslCalculus(); | |||
if (this.params.containsKey("LCOM")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vzurauskas Why not use an iteration on snippet :
if (this.params.containsKey(code)) {
reports.add(
new XslReport(
chain.transform(skeleton), new XslCalculus(code),
new ReportData(code, this.params, mean, sigma)
)
);
}
with code
, mean
and sigma
some parameters. You could use mean
and sigma
default values where it appears only two parameters in ReportData
constructor. You can also create a todo
for that if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baudoliver7 That is a good suggestion, however this PR has been blocked for a very long time and I no longer have the time to work on it (at least in the near future). You can take it over if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vzurauskas Ok. But how can I do that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baudoliver7 You can ask @paulodamaso to assign this task to you and then copy this branch.
@paulodamaso done in 18efdff |
@paulodamaso could you assign to me this PR ? I want to do some few changes on it. |
@paulodamaso ping |
Job |
PR for #481
Passing metric name via constructor to fit the Calculus interface to Java implementations.