-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS-28771 Remove version from agent JAR #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on the fix!
Could we add a simple check to the github actions pipeline (as suggested by @karottenreibe) that ensures the version number is not contained in the zip as expected?
sample-app/build.gradle
Outdated
// Needed to make git properties work with Java 8, see https://github.com/n0mer/gradle-git-properties/issues/195 | ||
configurations.all { | ||
resolutionStrategy { | ||
force 'org.eclipse.jgit:org.eclipse.jgit:5.13.0.202109080827-r' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not have an effect on the buildscript classpath (see failing build).
Could guess that this solution is required.
agent/build.gradle
Outdated
classifier = null | ||
// since this is used as an agent, we want it to always have the same name | ||
// otherwise people have to adjust their -javaagent parameters after every | ||
// update | ||
archiveVersion = null | ||
version = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move that version number reset out of the shadowJar block as it suggests that this is a property of the jar task, but actually this sets the version of the complete project.
agent/build.gradle
Outdated
@@ -54,12 +54,12 @@ shadowJar { | |||
// Needed as a workaround for https://github.com/johnrengelman/shadow/issues/521 | |||
inputs.property("debug", project.hasProperty("debug")) | |||
|
|||
archiveBaseName = 'teamscale-jacoco-agent' | |||
baseName = 'teamscale-jacoco-agent' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baseName is deprecated and will be removed in the next Gradle version. The documentation suggests to use archiveBaseName
instead. Are we sure that this is needed to get it back working?
4ca10d7
to
5ae23ec
Compare
87df68c
to
59ec699
Compare
Addresses issue TS-28771
Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.