From 448a951ea9f76c79306876e70cf782f33f0c5c2f Mon Sep 17 00:00:00 2001
From: Andreas Motl <andreas.motl@crate.io>
Date: Wed, 1 Nov 2023 15:42:57 +0100
Subject: [PATCH] Update to MLflow 2.8.0

MLflow 2.8.0 was released three days ago.
https://github.com/mlflow/mlflow/releases/tag/v2.8.0
---
 CHANGES.md                             |  1 +
 mlflow_cratedb/adapter/ddl/cratedb.sql |  1 +
 pyproject.toml                         |  2 +-
 tests/test_tracking.py                 | 10 +++++-----
 4 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/CHANGES.md b/CHANGES.md
index 6bd3fb4..092a334 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -2,6 +2,7 @@
 
 
 ## in progress
+- Update to MLflow 2.8.0
 
 ## 2023-11-01 v2.7.1
 - Fix uniqueness constraint with `SqlRegisteredModel.name`. Thanks, @andnig.
diff --git a/mlflow_cratedb/adapter/ddl/cratedb.sql b/mlflow_cratedb/adapter/ddl/cratedb.sql
index 16d749f..4a94cf6 100644
--- a/mlflow_cratedb/adapter/ddl/cratedb.sql
+++ b/mlflow_cratedb/adapter/ddl/cratedb.sql
@@ -72,6 +72,7 @@ CREATE TABLE IF NOT EXISTS "model_versions" (
    "user_id" TEXT,
    "current_stage" TEXT,
    "source" TEXT,
+   "storage_location" TEXT,
    "run_id" TEXT,
    "run_link" TEXT,
    "status" TEXT,
diff --git a/pyproject.toml b/pyproject.toml
index 2a6533a..448fbe8 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -79,7 +79,7 @@ dependencies = [
   "crash",
   "crate[sqlalchemy]>=0.34",
   "cratedb-toolkit==0.0.1",
-  "mlflow==2.7.1",
+  "mlflow==2.8",
   "sqlparse<0.5",
 ]
 
diff --git a/tests/test_tracking.py b/tests/test_tracking.py
index 508fbaa..40ea5ec 100644
--- a/tests/test_tracking.py
+++ b/tests/test_tracking.py
@@ -1128,13 +1128,13 @@ def test_log_null_param(self):
     def test_log_param_max_length_value(self):
         run = self._run_factory()
         tkey = "blahmetric"
-        tval = "x" * 500
+        tval = "x" * 6000
         param = entities.Param(tkey, tval)
         self.store.log_param(run.info.run_id, param)
         run = self.store.get_run(run.info.run_id)
         assert run.data.params[tkey] == str(tval)
         with pytest.raises(MlflowException, match="exceeded length"):
-            self.store.log_param(run.info.run_id, entities.Param(tkey, "x" * 1000))
+            self.store.log_param(run.info.run_id, entities.Param(tkey, "x" * 6001))
 
     @pytest.mark.skip("[FIXME] ColumnValidationException"
                       "[Validation failed for experiment_id: Updating a primary key is not supported]")
@@ -2744,11 +2744,11 @@ def test_log_batch_null_metrics(self):
 
     def test_log_batch_params_max_length_value(self):
         run = self._run_factory()
-        param_entities = [Param("long param", "x" * 500), Param("short param", "xyz")]
-        expected_param_entities = [Param("long param", "x" * 500), Param("short param", "xyz")]
+        param_entities = [Param("long param", "x" * 6000), Param("short param", "xyz")]
+        expected_param_entities = [Param("long param", "x" * 6000), Param("short param", "xyz")]
         self.store.log_batch(run.info.run_id, [], param_entities, [])
         self._verify_logged(self.store, run.info.run_id, [], expected_param_entities, [])
-        param_entities = [Param("long param", "x" * 1000)]
+        param_entities = [Param("long param", "x" * 6001)]
         with pytest.raises(MlflowException, match="exceeded length"):
             self.store.log_batch(run.info.run_id, [], param_entities, [])