fix: Dialogs are sometimes concealed #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crc-org#93 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
anjannath
approved these changes
May 15, 2023
gbraad
requested changes
May 15, 2023
| @@ -88,7 +88,7 @@ export async function startCrc( | |||
| } | |||
|
|
|||
| async function askAndStorePullSecret(logger: extensionApi.Logger): Promise<boolean> { | |||
| extensionApi.window.showInformationMessage( | |||
| await extensionApi.window.showInformationMessage( | |||
There was a problem hiding this comment.
we did this purposely... Can you remove this from the PR as this will be changed anyway due to #1920
This made the information show at the same time as the inputdialog (preventing people to miss it and put focus on PD). However, since MarkddownDescription has been added, this temporary solution can be removed.
Ref: #101 (review)
There was a problem hiding this comment.
I'm going to delete that message in my next PR with MarkddownDescription
There was a problem hiding this comment.
We can go ahead and just merge this...
evidolob
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93