From feeaf9f8bc3f549c9e9e8726dd28c7d9a14cd2b0 Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Tue, 19 Apr 2022 13:09:16 +0200 Subject: [PATCH] preflight: Reword checkM1CPU error message The M1 CPU check is checking for running crc as an emulated x86_64 binary on M1 CPUs. This is not a check which detects M1 CPUs and errors out regardless of the binary arch. This rewords the error message to make this clearer. --- pkg/crc/preflight/preflight_checks_darwin.go | 2 +- pkg/crc/preflight/preflight_darwin.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/crc/preflight/preflight_checks_darwin.go b/pkg/crc/preflight/preflight_checks_darwin.go index 10d59b3794..d9082d539a 100644 --- a/pkg/crc/preflight/preflight_checks_darwin.go +++ b/pkg/crc/preflight/preflight_checks_darwin.go @@ -29,7 +29,7 @@ const ( func checkM1CPU() error { if strings.HasPrefix(cpuid.CPU.BrandName, "VirtualApple") { logging.Debugf("Running with an emulated x86_64 CPU") - return fmt.Errorf("CRC is unsupported on Apple M1 hardware") + return fmt.Errorf("This version of CRC for AMD64/Intel64 CPUs is unsupported on Apple M1 hardware") } return nil diff --git a/pkg/crc/preflight/preflight_darwin.go b/pkg/crc/preflight/preflight_darwin.go index 48fc570f6b..68ac742f7a 100644 --- a/pkg/crc/preflight/preflight_darwin.go +++ b/pkg/crc/preflight/preflight_darwin.go @@ -17,7 +17,7 @@ func hyperkitPreflightChecks(networkMode network.Mode) []Check { configKeySuffix: "check-m1-cpu", checkDescription: "Checking if running emulated on a M1 CPU", check: checkM1CPU, - fixDescription: "CRC is unsupported on Apple M1 hardware", + fixDescription: "This version of CRC for AMD64/Intel64 CPUs is unsupported on Apple M1 hardware", flags: NoFix, labels: labels{Os: Darwin},