Improve handling of unknown fields in parameter structs #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A possible solution for #31.
radeksimko
approved these changes
Nov 18, 2020
- Unexport the StrictFielder interface. - Rename the method to DisallowUnknownFields. - Fix some documentation errors.
When unmarshaling parameters without the strict field check, don't create a byte reader and decoer; just call json.Unmarshal directly.
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31.
Commit 78545e2 disallowed unknown struct fields when unmarshaling parameters. The check could be bypassed by implementing the
json.Unmarshalerinterface, but the need to do so causes friction for implementations of LSP, which has a loose and rapidly-changing schema (see #5, #31).This changes the default back to ignoring unknown fields, and adds a new optional interface to re-enable strict checking without a custom unmarshaler.
N.B.: This is a breaking API change.