Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of unknown fields in parameter structs #32

Merged
merged 8 commits into from
Nov 18, 2020
Merged

Improve handling of unknown fields in parameter structs #32

merged 8 commits into from
Nov 18, 2020

Commits on Nov 17, 2020

  1. WIP: Add UnknownFielder interface. 

    A possible solution for #31.
    @creachadair
    creachadair committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    1200948 View commit details
    Browse the repository at this point in the history

  2. WIP: Update documentation.

    @creachadair
    creachadair committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    5701a55 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. WIP: Permit unknown fields by default.

    @creachadair
    creachadair committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    e825541 View commit details
    Browse the repository at this point in the history

  2. WIP: Update method name. 

    - Unexport the StrictFielder interface.
- Rename the method to DisallowUnknownFields.
- Fix some documentation errors.
    @creachadair
    creachadair committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    a3de7d4 View commit details
    Browse the repository at this point in the history

  3. WIP: Don't create a decoder if not needed. 

    When unmarshaling parameters without the strict field check, don't create a
byte reader and decoer; just call json.Unmarshal directly.
    @creachadair
    creachadair committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    60da453 View commit details
    Browse the repository at this point in the history

  4. WIP: Support strict field checks in UnmarshalResult too.

    @creachadair
    creachadair committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    3ccb76b View commit details
    Browse the repository at this point in the history

  5. WIP: use type switches.

    @creachadair
    creachadair committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    1d0022b View commit details
    Browse the repository at this point in the history

  6. WIP: update tests.

    @creachadair
    creachadair committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    d3f7574 View commit details
    Browse the repository at this point in the history