Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: panic while processing nested map and slice of structures #152 #154

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix: panic while processing nested map and slice of structures #152 #154

merged 1 commit into from
Oct 9, 2024

Conversation

XIELongDragon
Copy link
Contributor

@XIELongDragon XIELongDragon commented Sep 25, 2024 •
edited
Loading

Fix: panic while processing nested map and slice of structures #152

I think this PR can also solve #150 #149 #147, but I did not test it.

like parsing the following toml

foo = "value1"
bar = "value2"

[outter]
  [outter.inner]
    [[outter.inner.t1]]
      a = "a"
      b = "b"
    [[outter.inner.t1]]
      a = "c"
      b = "d"

@XIELongDragon
Copy link
Contributor Author

@cristaloleg pls help to review the PR.

@cristaloleg
Copy link
Member

Will take a look today, thanks!

@XIELongDragon
Copy link
Contributor Author

hi @cristaloleg any comments?

@cristaloleg cristaloleg merged commit 7111e04 into cristalhq:main Oct 9, 2024
3 checks passed
@cristaloleg
Copy link
Member

Thanks, released as https://github.com/cristalhq/aconfig/releases/tag/v0.18.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XIELongDragon @cristaloleg