Test using consul container instead of plain binaries stored in the repo #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2024 17:13
Drop support for 1.13 and 1.15 (partially for convenience as they're not in the hashicorp docker repo). We now also capture container logs and store them in a logs/ folder. Each test will have its own consul log file. A few linter changes required due to a ruff upgrade.
mbrulatout
requested review from
mougams,
cpaillet,
dclaisse,
pierrecdn and
manu-ns
mbrulatout
changed the title
added 6 commits
August 26, 2024 18:44
mougams
approved these changes
Aug 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for 1.13 and 1.15 (partially for convenience as
they're not in the hashicorp docker repo).
We now also capture container logs and store them in a logs/
folder. Each test will have its own consul log file.
This required a conftest.py split, where Consul agent creation fixture remain in the tests/ folder
to avoid cyclic import, while all the other parts are moved to the uppermost folder.
A few linter changes required due to a ruff upgrade.
An old deprecated setuptools test feature has been removed too.
Fixed some flakiness by increasing a few sleeps. HTTP checks also have a minimal timeout of 1s hardcoded into consul.