feat: add replace_existing_checks option to Catalog.register() #85
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpaillet
requested review from
dclaisse,
pierrecdn,
mbrulatout,
mougams and
a team
- Introduced `replace_existing_checks` parameter in the `register()` method to allow deletion of missing health checks from the request. - Ensures idempotent registration of services and their checks without needing manual deregistration of checks.
- Added "R0917" to the list of disabled checks in pyproject.toml to prevent errors for methods with too many positional arguments.
pierrecdn
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace_existing_checksparameter in theregister()method to allow deletion of missing health checks from the request.