Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skydock thinks an image is untagged if the it has 2 names #80

Open
jderusse opened this issue Nov 7, 2014 · 1 comment
Open

Skydock thinks an image is untagged if the it has 2 names #80

jderusse opened this issue Nov 7, 2014 · 1 comment

Comments

@jderusse
Copy link

jderusse commented Nov 7, 2014

If you tag the same commit with 2 differents image's name, when you start the containers with image A, docker may register image B un the Config section. It's not a problem except for skydock who thinks that the image is not tagged and returne a ErrImageNotTagged error.

$ docker images | grep d3b7d9f39158
foo-mailcatcher                                       latest                d3b7d9f39158        5 days ago          381.3 MB
bar-mailcatcher                                      latest                d3b7d9f39158        5 days ago          381.3 MB

$ docker run -d --name foo foo-mailcatcher
b9c81f106ad0509edc15d34305bb26ba766a465462d4a3a0f20f0f75e239e069
$ docker run -d --name bar bar-mailcatcher
80a7fe67d59d92b88d2121a75ce3b4e3bb9c19105e2f167bfaa79ceb288ca78a

$ docker inspect --format '{{ .Config.Image }}' foo
bar-mailcatcher

$ docker inspect --format '{{ .Config.Image }}' bar
bar-mailcatcher

The first image will raise a ErrImageNotTagged in skydns

@jderusse jderusse changed the title Skydock think an image is taged if the image has 2 differents names Skydock thinks an image is untagged if the it has 2 names Nov 7, 2014
@jderusse
Copy link
Author

jderusse commented Nov 7, 2014

If I remove this lines https://github.com/crosbymichael/skydock/blob/master/docker/client.go#L111:L113 ,it's works fine.

What's the reason of this part of the client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant