Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce maximum allowed Terraform version #9

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

jbw976
Copy link
Member

@jbw976 jbw976 commented Jun 5, 2024

Description of your changes

This PR applies the changes from crossplane/upjet-provider-template#67 to this repository.

In the Crossplane project, we cannot use a version of Terraform greater than v1.5.x because of the not permitted BSL license that was introduced starting with v1.6.0.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I have tested locally that the build still completes successful with make and make reviewable still passes all tests/checks. Of particular note is that no CRD schemas are affected by this change.

I would appreciate a critical look here to see if there's more manual testing we can perform to validate this change, as I am rolling this out across a number of providers I'm not super familiar with 😇

Signed-off-by: Jared Watts <jbw976@gmail.com>
Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976 jbw976 requested a review from tampakrap as a code owner June 5, 2024 20:31
@tampakrap tampakrap self-assigned this Jun 5, 2024
@tampakrap tampakrap merged commit ba24032 into crossplane-contrib:main Jun 5, 2024
8 checks passed
@jbw976
Copy link
Member Author

jbw976 commented Jun 5, 2024

Thank you for accepting this so quickly @tampakrap - we should get a new release out with this update. I think I have permissions to do that myself - would you like me to take care of that? 🙇‍♂️

@tampakrap
Copy link
Collaborator

Don't worry I'll handle it #10

@tampakrap
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants