From 5f85c5cf570003557966ff62711e3f74aed3743c Mon Sep 17 00:00:00 2001
From: Andrew Azores <aazores@redhat.com>
Date: Thu, 12 Oct 2023 15:52:44 -0400
Subject: [PATCH] fix(build): use vertx-dependencies and netty-bom for version
 management (#1720)

(cherry picked from commit c1da58d1f1c28b39b2cad0d2fc71741759297db7)
---
 pom.xml | 32 ++++++++++++++++++++++----------
 1 file changed, 22 insertions(+), 10 deletions(-)

diff --git a/pom.xml b/pom.xml
index e1c0167532..5c6f726d3d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -94,13 +94,11 @@
   <org.apache.commons.io.version>2.13.0</org.apache.commons.io.version>
   <org.apache.httpcomponents.version>4.5.14</org.apache.httpcomponents.version>
   <io.fabric8.client.version>6.7.2</io.fabric8.client.version>
-  <io.vertx.web.version>4.4.4</io.vertx.web.version>
-  <!-- https://repo1.maven.org/maven2/io/vertx/vertx-dependencies/${io.vertx.web.version}/vertx-dependencies-${io.vertx.web.version}.pom -->
-  <!-- https://groups.google.com/g/vertx/c/uzzcgw-YuOg -->
-  <io.netty.netty-transport-native-epoll.version>4.1.94.Final</io.netty.netty-transport-native-epoll.version><!-- FIXME this should be tied to the vertx version -->
+  <io.netty.version>4.1.94.Final</io.netty.version>
+  <io.vertx.version>4.4.4</io.vertx.version>
   <!--
     FIXME this needs to be synced with the vertx version - is there a BOM to use or something?
-    https://github.com/vert-x3/vertx-web/blob/${io.vertx.web.version}/vertx-web-graphql/pom.xml#L35
+    https://github.com/vert-x3/vertx-web/blob/${io.vertx.version}/vertx-web-graphql/pom.xml#L35
   -->
   <com.graphql.java.extended.scalars.version>20.2</com.graphql.java.extended.scalars.version>
   <com.nimbusds.jose.jwt.version>9.31</com.nimbusds.jose.jwt.version>
@@ -127,6 +125,25 @@
   <shellcheck-maven-plugin.version>0.5.1</shellcheck-maven-plugin.version>
 </properties>
 
+<dependencyManagement>
+  <dependencies>
+    <dependency>
+      <groupId>io.netty</groupId>
+      <artifactId>netty-bom</artifactId>
+      <version>${io.netty.version}</version>
+      <type>pom</type>
+      <scope>import</scope>
+    </dependency>
+    <dependency>
+      <groupId>io.vertx</groupId>
+      <artifactId>vertx-dependencies</artifactId>
+      <version>${io.vertx.version}</version>
+      <type>pom</type>
+      <scope>import</scope>
+    </dependency>
+  </dependencies>
+</dependencyManagement>
+
 <dependencies>
   <dependency>
     <groupId>io.cryostat</groupId>
@@ -181,17 +198,14 @@
   <dependency>
     <groupId>io.vertx</groupId>
     <artifactId>vertx-web</artifactId>
-    <version>${io.vertx.web.version}</version>
   </dependency>
   <dependency>
     <groupId>io.vertx</groupId>
     <artifactId>vertx-web-client</artifactId>
-    <version>${io.vertx.web.version}</version>
   </dependency>
   <dependency>
     <groupId>io.vertx</groupId>
     <artifactId>vertx-web-graphql</artifactId>
-    <version>${io.vertx.web.version}</version>
   </dependency>
   <dependency>
     <groupId>com.graphql-java</groupId>
@@ -1036,7 +1050,6 @@
         <groupId>io.netty</groupId>
         <artifactId>netty-transport-native-epoll</artifactId>
         <classifier>${io.netty.netty-transport-native-epoll.classifier}</classifier>
-        <version>${io.netty.netty-transport-native-epoll.version}</version>
         <scope>${io.netty.netty-transport-native-epoll.scope}</scope>
       </dependency>
     </dependencies>
@@ -1057,7 +1070,6 @@
         <groupId>io.netty</groupId>
         <artifactId>netty-transport-native-epoll</artifactId>
         <classifier>${io.netty.netty-transport-native-epoll.classifier}</classifier>
-        <version>${io.netty.netty-transport-native-epoll.version}</version>
         <scope>${io.netty.netty-transport-native-epoll.scope}</scope>
       </dependency>
     </dependencies>