Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(make): update Makefile targets to support ClusterCryostat #541

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Mar 17, 2023

This fixes make deploy to work across multiple namespaces. Permissions for resources created by the operator are converted from single-namespace to cluster-wide permissions. It also adds make create_clustercryostat and destroy_clustercryostat analogues to the existing targets for the Cryostat CR. WATCH_NAMESPACE is set to the empty string, which signals the manager to watch all namespaces.

Fixes: #522

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Elliott Baron <ebaron@redhat.com>
Signed-off-by: Elliott Baron <ebaron@redhat.com>
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ebaron ebaron merged commit 959e986 into cryostatio:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Makefile targets for multi-namespace support
3 participants