switch rooms #330
Merged
switch rooms #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elimisteve
reviewed
Mar 6, 2023
src/components/chat/RoomList.js
Outdated
| {roomList.map((passphrase) => { | ||
| <li className="current-room"> | ||
| {displayRoomName(passphraseFromUrlHash)}{' '} | ||
| </li> |
Member
There was a problem hiding this comment.
@jimmcgaw Isn't it better to have a consistent room ordering, rather than moving the current room to the top?
Member
There was a problem hiding this comment.
Seems easier to navigate, like in Slack or Discord. Yes?
Collaborator
Author
There was a problem hiding this comment.
Honestly, I don't know.
Member
There was a problem hiding this comment.
Okay I'm 90% sure leaving the same room ordering is best. Please make this tweak then let's merge?
elimisteve
reviewed
Mar 6, 2023
elimisteve
reviewed
Mar 6, 2023
jimmcgaw
force-pushed
the
cap2_room_switching
branch
from
75c7162 to
d342e6e
Compare
elimisteve
reviewed
Mar 6, 2023
| }; | ||
| const setPassphrase = (passphrase) => { | ||
| console.log('setPassphrase() -- TODO: Disconnect the WebSocket, change the current URL hash, auth again, connect via WebSocket'); | ||
| }; |
Member
There was a problem hiding this comment.
Let's nuke this function but... who cares! Room switching ftw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.