fix: memiavl WriteSnapshotWithContext cancel using wrong ctx (#7)

songgaoye · web-flow · commit a2ef3db35407 · 2025-10-22T08:21:48.000Z
* fix:memiavl WriteSnapshotWithContext cancel

* fix lint

* add changelog
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
 - [#1](https://github.com/crypto-org-chain/cronos-store/pull/1) feature: add store, memiavl, versiondb.
 - [#3](https://github.com/crypto-org-chain/cronos-store/pull/3) feat(memiavl): MultiTree add chainId.
-- [#4](https://github.com/crypto-org-chain/cronos-store/pull/4) feat(versiondb/client): add dump versiondb changeset cmd.
+- [#4](https://github.com/crypto-org-chain/cronos-store/pull/4) feat(versiondb/client): add dump versiondb changeset cmd.
+- [#7](https://github.com/crypto-org-chain/cronos-store/pull/7) fix: memiavl WriteSnapshotWithContext cancel using wrong ctx.
diff --git a/memiavl/multitree.go b/memiavl/multitree.go
@@ -378,7 +378,8 @@ func (t *MultiTree) WriteSnapshotWithContext(ctx context.Context, dir string, wp
 	}
 
 	// write the snapshots in parallel and wait all jobs done
-	group, _ := wp.GroupContext(context.Background())
+	// group, _ := wp.GroupContext(context.Background())
+	group, _ := wp.GroupContext(ctx)
 
 	for _, entry := range t.trees {
 		tree, name := entry.Tree, entry.Name
diff --git a/memiavl/multitree_test.go b/memiavl/multitree_test.go

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,8 @@ func (t *MultiTree) WriteSnapshotWithContext(ctx context.Context, dir string, wp`
`378`	`378`	`}`
`379`	`379`
`380`	`380`	`// write the snapshots in parallel and wait all jobs done`
`381`		`- group, _ := wp.GroupContext(context.Background())`
	`381`	`+ // group, _ := wp.GroupContext(context.Background())`
	`382`	`+ group, _ := wp.GroupContext(ctx)`
`382`	`383`
`383`	`384`	`for _, entry := range t.trees {`
`384`	`385`	`tree, name := entry.Tree, entry.Name`