Skip to content

Conversation

@randy-cro
Copy link
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@randy-cro randy-cro requested a review from a team as a code owner November 19, 2025 07:10
@randy-cro randy-cro requested review from JayT106 and songgaoye and removed request for a team November 19, 2025 07:10
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

socket-security bot commented Nov 19, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​crypto-org-chain/​cosmos-sdk@​v0.50.6-0.20251114132341-ca3cb50f8d06 ⏵ v0.50.6-0.20251119062431-8d0a31ef043d76 +1100100100100

View full report

@github-actions github-actions bot added the ci label Nov 19, 2025
@randy-cro randy-cro force-pushed the backport/improve-mint-params-validation-25562 branch from 13f4ad8 to 12ded49 Compare November 19, 2025 07:32
Signed-off-by: randy-cro <randy.ang@crypto.com>
@randy-cro randy-cro enabled auto-merge (squash) November 19, 2025 08:29
@randy-cro randy-cro merged commit 308d80e into crypto-org-chain:release/v1.6.x Nov 19, 2025
50 checks passed
@randy-cro randy-cro deleted the backport/improve-mint-params-validation-25562 branch November 19, 2025 08:59
randy-cro added a commit to randy-cro/cronos that referenced this pull request Nov 19, 2025
…mos-sdk (backport #25562) (crypto-org-chain#1918)

* update cosmos-sdk (backport #26652) - improve mint params validation

* add integration tests

* fix python lint

* remove comment

Signed-off-by: randy-cro <randy.ang@crypto.com>

---------

Signed-off-by: randy-cro <randy.ang@crypto.com>
github-merge-queue bot pushed a commit that referenced this pull request Nov 19, 2025
…s-sdk (backport #25562) (#1919)

* chore: cleanup and improve `x/mint` params validation and test in cosmos-sdk (backport #25562) (#1918)

* update cosmos-sdk (backport #26652) - improve mint params validation

* add integration tests

* fix python lint

* remove comment

Signed-off-by: randy-cro <randy.ang@crypto.com>

---------

Signed-off-by: randy-cro <randy.ang@crypto.com>

* fix minor f print

---------

Signed-off-by: randy-cro <randy.ang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants