Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a troubleshooting section for macOS mojave #312

Merged
merged 8 commits into from
Jun 5, 2019

Conversation

ctrl-dlahr
Copy link
Contributor

@ctrl-dlahr ctrl-dlahr commented Dec 30, 2018

I ran into this issue recently trying out crystal and hoped to contribute!

crystal-7209

@straight-shoota
Copy link
Member

Other relevant issue: crystal-lang/crystal#6875

@RX14
Copy link
Contributor

RX14 commented Jan 2, 2019

Can't someone who uses homebrew just work out a solution to make homebrew package crystal properly? If it doesn't work out the box, it's a packaging problem, not crystal's problem.

@proyb6
Copy link

proyb6 commented Jan 2, 2019

I concur, it’s a HomeBrew’s issue that devs have to googling manually for more than one way and work differently on different terminals. Could not recommend adding this advice on Crystal book.

@ctrl-dlahr
Copy link
Contributor Author

ctrl-dlahr commented Jan 2, 2019

@RX14 The Crystal Playground will not work on macOS Mojave without this troubleshooting step. I, as someone new to crystal thought it was really frustrating to figure out and considered not bothering since it was not an easy search. I was just casually checking it out which I think is common.

In my opinion if it is a problem that occurs for all or most X users you should add it to the troubleshooting guide to make the Crystal experience better for those users.

Crystal now installs pkg-config by default, but it doesn't expose that to OpenSSL installation and thus the crystal playground will always be broken until it is linked for macOS Mojave users.

Up to you guys :) appreciate your taking the time to review the pull request

@proyb6
Copy link

proyb6 commented Jan 2, 2019

@codingdracula I checked yesterday pkg-config wasn’t installed by default

@ctrl-dlahr
Copy link
Contributor Author

@proyb6 apologies, everyone should ignore the last part of my post. I didn't realize it was still open

@straight-shoota
Copy link
Member

@codingdracula Thank you! Your contribution is very welcome. I think we should definitely merge this as a service to Crystal users in MacOS. Unless there is a way to avoid this problem altogether as @RX14 asked. That would be even better, if no troubleshooting was required in the first place.

@RX14
Copy link
Contributor

RX14 commented Jan 2, 2019

In the short term we should merge this PR, but only after we've bought up this issue with homebrew, or the issue will end up being neglected.

installation/on_mac_osx_using_homebrew.md Show resolved Hide resolved
installation/on_mac_osx_using_homebrew.md Outdated Show resolved Hide resolved
installation/on_mac_osx_using_homebrew.md Outdated Show resolved Hide resolved
@gregors
Copy link

gregors commented Mar 18, 2019

@dustinlahr thanks for helping me solve my problem

@straight-shoota
Copy link
Member

@dustinlahr Could you apply the suggestions from @bcardiff ?

bcardiff and others added 2 commits April 2, 2019 12:10
installation/on_mac_osx_using_homebrew.md Outdated Show resolved Hide resolved
installation/on_mac_osx_using_homebrew.md Outdated Show resolved Hide resolved
installation/on_mac_osx_using_homebrew.md Outdated Show resolved Hide resolved
installation/on_mac_osx_using_homebrew.md Outdated Show resolved Hide resolved
installation/on_mac_osx_using_homebrew.md Outdated Show resolved Hide resolved
wooster0 and others added 5 commits April 2, 2019 13:00
Co-Authored-By: dustinlahr <dustin.lahr.367@my.csun.edu>
Co-Authored-By: dustinlahr <dustin.lahr.367@my.csun.edu>
Co-Authored-By: dustinlahr <dustin.lahr.367@my.csun.edu>
Co-Authored-By: dustinlahr <dustin.lahr.367@my.csun.edu>
Co-Authored-By: dustinlahr <dustin.lahr.367@my.csun.edu>
@dkniffin
Copy link

dkniffin commented Apr 20, 2019

Not sure if it belongs as part of this PR or another one, but this page on the website needs to be updated as well: https://luckyframework.org/guides/installing/

Right now it says:

If you are on macOS High Sierra ...

but I think Mojave needs to be listed there as well

Copy link
Contributor Author

@ctrl-dlahr ctrl-dlahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added requested changes @bcardiff. Not sure if there is anything else I need to do. If there is let me know :)!

@bcardiff bcardiff merged commit 4049889 into crystal-lang:master Jun 5, 2019
@bcardiff
Copy link
Member

bcardiff commented Jun 5, 2019

Thanks @dustinlahr

@RX14
Copy link
Contributor

RX14 commented Jun 21, 2019

Has anyone been working on fixing this packaging issue? I'd do it myself if I had a mac.

@bcardiff
Copy link
Member

@RX14 what could be changed to delay the issue is to avoid the dependency of ssl with the playground agent. Using pipes or sockets will be enough.

Other than that, when compiling an http server eventually the user will need some ssl and pkg-config configured accordingly.

@rdp
Copy link
Contributor

rdp commented Nov 15, 2019

Something doesn't feel quite right. Crystal is installed via a package manager. Then it subsequently cannot use the SSL dependency that was pulled in by the same package manager. At worst crystal should have a warning message in its brew package (at install time) but this should probably "just work" ... sadly it appears the instruction page is a bit outdated (you don't need to install openssl anymore, manually, and the path is now /usr/local/opt/openssl@1.1 FWIW)

@bcardiff
Copy link
Member

I agree, eventually crystal via brew might have a wrapper script that will set up accordings paths to link directly to OpenSSL in brew probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants