Add page: Crystal 1.0 Conference #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crystal-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
straight-shoota
force-pushed
the
feat/conference-1.0
branch
from
9382b65 to
39484ac
Compare
beta-ziliani
approved these changes
Jul 24, 2023
Dunno. It's a bit of legwork, but likely not complicated. Have to track the images in Airtable. Probably put them in the repo to be future proof. And then replace the URLs in https://github.com/crystal-lang/crystal-website/blob/master/_data/conference_talks.csv |
|
I added it as a polish task for the future. This is good to go 🚀 |
|
I don't think fixing the images belongs in the scope of the relaunch. It's already broken in the current page: https://crystal-lang.org/events/2021-crystal-1.0/ EDIT: Create a separate issue for that: #490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speaker icons are missing. They are pulled directly from airtable which probably isn't the best idea. This is broken in the current website already and I'm not sure it's worth fixing. It should be a separate change though.
Goes on top of #480