Update filterFallbacks to be selective rather than all-or-nothing #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samalws-tob
changed the title
arcz
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
filterFallbacksfunction so that it filters out fallbacks selectively, rather than either removing fallbacks from all contracts or none. It also removes the first argument of the function, which was unused.Fixes issue 1 of #1134 (now it's 1000 calls/s in both cases, rather than 1000 in one and 10000 in the other; the performance only improved before because it was trying a bunch of fallback calls, which executed quickly because they didn't do anything)