Cleanup imports and extensions #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcz
force-pushed
the
imports-extensions-cleanup
branch
from
07de276 to
099633e
Compare
arcz
force-pushed
the
imports-extensions-cleanup
branch
from
099633e to
8ac6930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new
ImportQualifiedPostextensions that allows more natural placement ofqualifiedkeyword. I cleaned up the imports alphabetically, dividing them into common, hevm, and echidna as we tend to style this and made this consistent throughout the codebase.We also use a lot of extensions that will become standard starting from GHC 9.2 - https://ghc.gitlab.haskell.org/ghc/doc/users_guide/exts/control.html#extension-GHC2021. I removed those from the sources and placed them as default extensions. When we update to 9.2 we can simply remove them from
package.yaml.EDIT: I had to update hlint action as it was too old and didn't recognize
ImportQualifiedPost