From d07d63e68a2559d1a576299de04287d2ba5069b4 Mon Sep 17 00:00:00 2001 From: Andre Duffeck Date: Fri, 21 Jan 2022 12:28:11 +0100 Subject: [PATCH] Do not log nodes (#2463) * Do not log whole nodes It turns out that logging whole node objects is very expensive and also spams the logs quite a bit. Instead we just log the node ID now. * Add changelog --- changelog/unreleased/do-not-log-nodes.md | 6 ++++++ pkg/storage/utils/decomposedfs/node/node.go | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 changelog/unreleased/do-not-log-nodes.md diff --git a/changelog/unreleased/do-not-log-nodes.md b/changelog/unreleased/do-not-log-nodes.md new file mode 100644 index 00000000000..c3eaf0f4930 --- /dev/null +++ b/changelog/unreleased/do-not-log-nodes.md @@ -0,0 +1,6 @@ +Enhancement: do not log whole nodes + +It turns out that logging whole node objects is very expensive and also +spams the logs quite a bit. Instead we just log the node ID now. + +https://github.com/cs3org/reva/pull/2463 diff --git a/pkg/storage/utils/decomposedfs/node/node.go b/pkg/storage/utils/decomposedfs/node/node.go index 0ee8b18d91d..d92507149df 100644 --- a/pkg/storage/utils/decomposedfs/node/node.go +++ b/pkg/storage/utils/decomposedfs/node/node.go @@ -506,7 +506,7 @@ func (n *Node) SetFavorite(uid *userpb.UserId, val string) error { // AsResourceInfo return the node as CS3 ResourceInfo func (n *Node) AsResourceInfo(ctx context.Context, rp *provider.ResourcePermissions, mdKeys []string, returnBasename bool) (ri *provider.ResourceInfo, err error) { - sublog := appctx.GetLogger(ctx).With().Interface("node", n).Logger() + sublog := appctx.GetLogger(ctx).With().Interface("node", n.ID).Logger() var fn string nodePath := n.InternalPath()