Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

After inserting a wrong PAT once, the extension does not work even with a correct PAT #35

Closed
renanborgez opened this issue Jun 29, 2020 · 19 comments
Assignees
Labels
bug Something isn't working

Comments

@renanborgez
Copy link

renanborgez commented Jun 29, 2020

@cschleiden Sorry by the title, it does work indeed, however it was a bit tricky for me to discover that.

I installed the extension by the first time and I inserted a wrongly created PAT (with less permissions than necessary).
After trying using the extension (with the wrong PAT) I correctly received the An error has occurred message.

Reading the docs I realised that I should have added more permission. So I deleted my old PAT, created a new one with the right permissions and I inserted it in the extension by using the following menu:
image

After inserting the CORRECT PAT I've just received the following message:
image

I tried many times with the repo and workflow permissions enabled but the problem kept happening.
So I decided to try to uninstall and install it again. (also reloading the VSCode)

Even before inserting the PAT again, the extension started to work properly!!!!!!!

After trying many times this flow, I realised that is necessary to ALWAYS reload VSCode if you want to change the PAT.

Summarising:

Insert a wrong PAT, extension does not work, fix the PAT and insert it again, extension (still)does not work, reload VSCode, extension does work (without any changes).

@cschleiden
Copy link
Owner

Thanks for the detailed description and the repro steps!

The new vscode authentication API seems to be finally moving into the stable release, once that's done #20 should simplify all of this by a lot.

@FonsRademakers
Copy link

Same problem here. Regenerated PAT but where do I insert it?

@FonsRademakers
Copy link

Ok found it and restart of vscode solves it.

@cschleiden cschleiden added the bug Something isn't working label Jun 29, 2020
@cschleiden cschleiden changed the title [BUG] After inserting a wrong PAT once the extension does not work even with a correct PAT After inserting a wrong PAT once the extension does not work even with a correct PAT Jun 29, 2020
@cschleiden cschleiden self-assigned this Jun 29, 2020
@albertorm95
Copy link

any new about this?

@doitandbedone
Copy link

Having the same issue, even restarting does nothing, can the known workaround please be posted for the time being?

Thanks!

@renanborgez renanborgez changed the title After inserting a wrong PAT once the extension does not work even with a correct PAT After inserting a wrong PAT once, the extension does not work even with a correct PAT Jul 16, 2020
@cschleiden
Copy link
Owner

Using the login command and then reloading VS Code doesn't work?
What OS are you on?

@albertorm95
Copy link

@cschleiden MacOS, and no, login didn't work :(

@renanborgez
Copy link
Author

@cschleiden just to let you know, I'm also using MacOS (Catalina 10.15.5)

@akapur1784
Copy link

akapur1784 commented Jul 26, 2020

@cschleiden
Any update on this issue?

I am facing the same issue on MacOS.

@rajyraman
Copy link

I cannot get the auth working either event with correct token.

@cschleiden
Copy link
Owner

cschleiden commented Jul 29, 2020

When you store a new token, the old one should be overwritten. If not, you could manually delete it from the Keychain on MacOS:

image

@rajyraman
Copy link

@cschleiden - That was it 😄. I had to delete the credentials in Windows, re-enter and re-start code. It works now.

image

@cschleiden
Copy link
Owner

@rajyraman awesome, great to hear!

I really hope the VS Code team GAs the authentication API soon...

@akapur1784
Copy link

@cschleiden The solution provided for Mac OS did not work. :(

@cschleiden
Copy link
Owner

@cschleiden The solution provided for Mac OS did not work. :(

Hm, what do you mean by that? What did you do and what do you experience now?

@akapur1784
Copy link

@cschleiden
I deleted the credentials from Keychain, I entered the PAT in the login space again and restarted VS code.
I still get "An error has occurred :(" message

@akapur1784
Copy link

@cschleiden any update on this bug for Mac OS?

@cschleiden
Copy link
Owner

@akapur1784 I can't repro unfortunately. Could you open the vs code dev tools, do you see more details about the error there?

Otherwise I'm expecting the VS Code July release to drop any day now: microsoft/vscode#103792

Within a day or so after the release I'll be able to update the extension to not require the manual PAT entry.

@cschleiden
Copy link
Owner

I have just released version 0.7.0 with integrated VS Code authentication support, closing this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants