From fbc22da08632bf6dc92e7c517e5cef85adf87489 Mon Sep 17 00:00:00 2001 From: Mark Piper Date: Thu, 9 Jul 2020 14:46:33 -0600 Subject: [PATCH 1/4] Fix argument name in docstring --- bmipy/bmi.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bmipy/bmi.py b/bmipy/bmi.py index 660b76f..2596b79 100644 --- a/bmipy/bmi.py +++ b/bmipy/bmi.py @@ -12,7 +12,7 @@ def initialize(self, config_file: str) -> None: Perform all tasks that take place before entering the model's time loop, including opening files and initializing the model state. Model inputs are read from a text-based configuration file, specified by - `filename`. + `config_file`. Parameters ---------- From 32cf6d21385543b573fa7d01571f2cef0496522c Mon Sep 17 00:00:00 2001 From: Mark Piper Date: Thu, 9 Jul 2020 17:00:02 -0600 Subject: [PATCH 2/4] Add comment on origin of spec file --- bmipy/bmi.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/bmipy/bmi.py b/bmipy/bmi.py index 2596b79..aacf206 100644 --- a/bmipy/bmi.py +++ b/bmipy/bmi.py @@ -1,3 +1,10 @@ +"""The Basic Model Interface (BMI) Python specification. + +This language specification is derived from the Scientific Interface +Definition Language (SIDL) file bmi.sidl located at +https://github.com/csdms/bmi. +""" + from abc import ABC, abstractmethod from typing import Tuple From 8d3b50979f5e21465930302f5f5aa9ce403b43d7 Mon Sep 17 00:00:00 2001 From: Mark Piper Date: Thu, 9 Jul 2020 17:24:56 -0600 Subject: [PATCH 3/4] Fix miniconda download URL --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 5e5f392..23273d0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -42,7 +42,7 @@ before_install: fi - | if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then - curl https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh > $HOME/miniconda.sh + curl https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh > $HOME/miniconda.sh else curl https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh > $HOME/miniconda.sh fi From 6d77de93df7388f50bb340873ed224884e18795e Mon Sep 17 00:00:00 2001 From: Mark Piper Date: Thu, 9 Jul 2020 17:36:45 -0600 Subject: [PATCH 4/4] Also change URL for Linux download --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 23273d0..8111055 100644 --- a/.travis.yml +++ b/.travis.yml @@ -44,7 +44,7 @@ before_install: if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then curl https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh > $HOME/miniconda.sh else - curl https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh > $HOME/miniconda.sh + curl https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh > $HOME/miniconda.sh fi - bash $HOME/miniconda.sh -b -p $HOME/anaconda - export PATH="$HOME/anaconda/bin:$PATH"