-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerised build and test support for EMS #25
Open
sharon-tickell
wants to merge
22
commits into
csiro-coasts:dev
Choose a base branch
from
eReefs:recom2-dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.5.0 release based on SVN rev 7386
Include <math.h> at the top of emsmath.h so that the min and max macro definitions from /usr/include/c++/12/bits/stl_algobase.h take precedence over the ones with fewer arguments defined locally
v1.5.1 release based on SVN rev 7477
… first failure, not count missing output files as a failure
…it on first failure, not count missing output files as a failure
…ables, exit on first failure, not count missing output files as a failure
This was referenced Feb 6, 2024
…libs, so use that by default
…rather than defaulting to empty
Update to SVN rev 7501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes tweak several of the test scripts to:
With those changes made, we then add a script that can find and run all the individual tests and report on which ones pass and which ones fail (with a non-zero exitcode indicating failure).
I also add a Dockerfile and docker-compose definition to support building EMS and running all the tests in a standard, controlled environment: this is suitable for use in a continuous integration workflow.
By default, the docker build will compile all the EMS components, will run the tests as part of the build, and will fail the build if any of the tests fail. but this behaviour can be altered by configuring override values for build-time arguments.
The
docker-compose.yml
is configured to not run tests as part of the build, but instead to bind-mount the test files and run tests when the component starts. This is useful for test development. To make this only run a subset of tests, alter the value of the EMS_TEST_INCLUDE environment variable to be the path to the directory containing the test(s) you want to run.