-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alternative test name formatting #23
Comments
I guess the repro owners can only apply labels? This is meant to be an enhancement issue |
After thinking about it for a while, I'm not sure whether this is a good idea. Here's why:
Overall, it feels like we add quite a bit of complexity for a rather limited problem. @kornman00 Does this convince you? What do you think? |
Well, to the first point, Google Test Adapter adapts the tests to be interfaceable in VS' own Test Explorer. So I would expect there to be some settings to fix non 1:1 mapping quirks. Since I'm assuming the Test Explorer tree itself can't be tweaked, I would figure there could be an opt-in name setting to get around extreme cases, like presented in project above (I also believe I read somewhere that per-project settings could be set? So the opt-in could be per-project?). If a user honestly initially forgets they have the '/' character replacement setting active, I'd think the appearance of its replacement in such long test name sequences would make them go "oh yeah". Hovering over the entry in the tree is indeed a workaround. Sadly, I don't always have three monitors at my disposal to keep such windows always open. So personally, I keep the test explorer minimized along the left side of VS (not all projects I open include tests or require testing interaction on my part). I suppose in this case I can just have the Test Explorer expand all the way across my screen when I brush the cursor over the tab. A bit annoying, but managable. Of course, It could be that a backwards slash doesn't exhibit that truncation behavior. Or maybe a space before and after the forward slash bypasses the behavior. So perhaps there should be NO complexity to this limited problem...at the end of the day the problem is with how VS formats Google's instantiated cases (or are there other cases where GT uses forward slashes?), so perhaps some alternate concat string could be set by the user, instead of some full-fledged renaming policy. That's my 2c. I'll...adapt to whatever decision you arrive at. |
For the record:
|
Thanks for taking the time to address this! |
You're welcome! Just give us some time until the next release... |
* addressing feedback * Assorted fit-and-finish * Undo unfinished work for BatchFile resource * Fix some resources comments * Remove unused resources * Additional fixes
As discussed in #22, in the Test Explorer window if VS can't fit the text after a "/" (that's then terminated by another "/" or the EOS) then it shortens everything after that "/" with "...". Perhaps a replacement string could be provided in GTA's settings? Eg, instead of "/" a user could specify "->" or something else.
Here are truncated instantiated test cases:
And here they are when the window is expanded to fit the next segment:
The text was updated successfully, but these errors were encountered: