Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Backward incompatibility: Updates for px4 firmware v1.13.2 #150

Open
spurnvoj opened this issue Jan 17, 2023 · 8 comments
Open

📚 Backward incompatibility: Updates for px4 firmware v1.13.2 #150

spurnvoj opened this issue Jan 17, 2023 · 8 comments
Labels
users-read-me information to users about a backwards-incompatible change

Comments

@spurnvoj
Copy link
Member

spurnvoj commented Jan 17, 2023

This is an important notice for everyone using our system. In the case the MRS system was/is already locally built on your system, you need to do the following steps to have the system properly working:

  1. Remove uav_core and simulation repositories and clone them again.
  2. Clean the workspace containing uav_core and simulation repositories.
  3. Remove all folders sitl_uav$ in ~/.ros folder.
  4. Call the installation script in the uav_core repository.
  5. Build your workspace again.
@spurnvoj spurnvoj added documentation Improvements or additions to documentation users-read-me information to users about a backwards-incompatible change and removed documentation Improvements or additions to documentation labels Jan 17, 2023
@nrlhozkan
Copy link

nrlhozkan commented Feb 20, 2023

Hello. When I do that on my computer, files inside mrs_workspace/simulation/ ros_packages do not have folders like px4_firmware and vs. any longer. But, Inside git, the probably old folders, are still there. What should I do?

@spurnvoj
Copy link
Member Author

@nrlhozkan did you follow the first point?

Remove uav_core and simulation repositories and clone them again.

If yes, have you called gitman install in the root of the repositories? We are using gitman for managing the git repositories https://ctu-mrs.github.io/docs/software/gitman.html.

@nrlhozkan
Copy link

I have one workspace and one git folder. I delete, uav_core and simulation in src in my workspace. Then clone again in src. Then I did catkin clean to clean the workspace. Later delete sitl_uav in .ros. After that call the installation.sh in uav_core/installation. Finally build my workspace with catkin build. I did not use gitman install.

@spurnvoj
Copy link
Member Author

If you installed our system using the native way as it is described in README here https://github.com/ctu-mrs/mrs_uav_system#native-installation-not-recommended, the folders in workspace/src should be symlinks to the git folder. Therefore, you can delete simulation and uav_core folders in the workspace and the same files in the git folder. Then, go into mrs_uav_system folder in ~/git, update it, and call the install script:

cd ~/git/mrs_uav_system
git checkout master
git pull
./install.sh -g ~/git

This should properly download and compile everything.

@klaxalk
Copy link
Member

klaxalk commented Feb 21, 2023

And if you cloned uav_core or simulation manually, then you need to run gitman install to download the submodules. That will populate the respective uav_core/ros_packages and simulation/ros_packages folders.

@matemat13
Copy link
Member

If the install.sh script in uav_core fails with an error

ImportError: cannot import name 'OS_RASPBIAN' from 'rospkg.os_detect' (/usr/local/lib/python3.8/dist-packages/rospkg/os_detect.py)

see issue #154 for a solution.

@WingRS WingRS closed this as completed Mar 15, 2023
@WingRS WingRS reopened this Mar 15, 2023
@WingRS
Copy link
Member

WingRS commented Mar 15, 2023

When calling the install script in uav_core, I have faced an issue with some un-updated IP addresses, and maybe we could add sudo apt update in the install script. This is a simple issue but might confuse some people

@petrapa6
Copy link
Member

I also recommend to run the installation script in the simulation repository after step 4. It installed some missing dependencies for px4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
users-read-me information to users about a backwards-incompatible change
Projects
None yet
Development

No branches or pull requests

6 participants