From 1cf7148bc6b3d6d9d361154d2a7bca63d5246323 Mon Sep 17 00:00:00 2001 From: Mikhail Cheshkov Date: Wed, 20 Nov 2024 23:27:09 +0200 Subject: [PATCH] fix(clickhouse-driver): Replace error cause with string formatting Error cause is not properly propagated in REST API, so use direct formatting for now --- .../cubejs-clickhouse-driver/src/ClickHouseDriver.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts b/packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts index 0a55468a1e8f8..ddc7571b2f071 100644 --- a/packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts +++ b/packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts @@ -259,7 +259,8 @@ export class ClickHouseDriver extends BaseDriver implements DriverInterface { const results = await resultSet.json>(); return results; } catch (e) { - throw new Error(`Query failed; query id: ${queryId}, SQL: ${query}`, { cause: e }); + // TODO replace string formatting with proper cause + throw new Error(`Query failed; cause: ${e}; query id: ${queryId}; SQL: ${query}`); } }); } @@ -407,7 +408,8 @@ export class ClickHouseDriver extends BaseDriver implements DriverInterface { }; } catch (e) { await client.close(); - throw new Error(`Stream query failed; query id: ${queryId}, SQL: ${query}`, { cause: e }); + // TODO replace string formatting with proper cause + throw new Error(`Stream query failed; cause: ${e}; query id: ${queryId}; SQL: ${query}`); } } @@ -551,7 +553,8 @@ export class ClickHouseDriver extends BaseDriver implements DriverInterface { try { await this.command(createTableSql); } catch (e) { - throw new Error(`Error during create table: ${createTableSql}`, { cause: e }); + // TODO replace string formatting with proper cause + throw new Error(`Create table failed; cause: ${e}; SQL: ${createTableSql}`); } }