Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Render LIMIT 0 and OFFSET 0 properly in SQL templates #8781

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: Render LIMIT 0 and OFFSET 0 properly in SQL templates #8781

merged 1 commit into from
Oct 9, 2024

Commits on Oct 9, 2024

  1. fix: Render LIMIT 0 and OFFSET 0 properly in SQL templates 

    `if limit` condition in Jinja will fail for both None and Some(0)
This is more or less fine for offset, but completely wrong for limit. For consistency both are changed.

Also add unit test in SQL API and smoke E2E test
    @mcheshkov
    mcheshkov committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4e1ca10 View commit details
    Browse the repository at this point in the history