PR時にChatGPTのレビューを挟む #125
PR時にChatGPTのレビューを挟む #125
Conversation
|
ウォークスルーこの変更は、AIベースのPRレビュアーを使用してコードレビューを行うGitHub Actionsワークフローファイルを追加します。これにより、OpenAIの言語モデルがコードの品質向上と重要な領域の改善を支援します。 変更点
ポエム
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (1)
- .github/workflows/ai-pr-reviewer.yml (1)
Review comments generated (1)
- Review: 1
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
.github/workflows/ai-pr-reviewer.yml
Outdated
| name: Code Review | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| on: | ||
| pull_request: | ||
| pull_request_review_comment: | ||
| types: [ created ] | ||
|
|
||
| concurrency: | ||
| group: | ||
| ${{ github.repository }}-${{ github.event.number || github.head_ref || | ||
| github.sha }}-${{ github.workflow }}-${{ github.event_name == | ||
| 'pull_request_review_comment' && 'pr_comment' || 'pr' }} | ||
| cancel-in-progress: ${{ github.event_name != 'pull_request_review_comment' }} | ||
|
|
||
| jobs: | ||
| review: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: AI-based PR Reviewer & Summarizer with Chat Capabilities | ||
| uses: coderabbitai/ai-pr-reviewer@latest | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
| with: | ||
| debug: false | ||
| review_simple_changes: false | ||
| review_comment_lgtm: false | ||
| openai_light_model: gpt-3.5-turbo | ||
| openai_heavy_model: gpt-4 | ||
| system_message: | | ||
| あなたは `@coderabbitai`（別名 `github-actions[bot]`）で、OpenAIによってトレーニングされた言語モデルです。 | ||
| あなたの目的は、非常に経験豊かなソフトウェアエンジニアとしてコードの断片を徹底的にレビューし、以下のような重要な領域を改善するためのコードスニペットを提案することです： | ||
| - Logic | ||
| - Security | ||
| - Performance | ||
| - Data races | ||
| - Consistency | ||
| - Error handling | ||
| - Maintainability | ||
| - Modularity | ||
| - Complexity | ||
| - Optimization | ||
| - Best practices: DRY, SOLID, KISS | ||
|
|
||
| 細かいコードスタイルの問題や、コメント/ドキュメントの不足についてはコメントしないでください。 | ||
| 重要な懸念を特定し、解決することで全体的なコード品質を向上させ、一方で細かい問題は意図的に無視してください。 |
There was a problem hiding this comment.
The GitHub Actions workflow file looks good overall. However, there's a potential issue with the concurrency group definition. The current setup might lead to unexpected cancellation of jobs.
In your concurrency group definition, you're using github.head_ref which is only available for pull_request events and not for pull_request_review_comment events. This could potentially lead to different concurrency groups for the same PR under different events, which might not be what you want.
Here's a suggested change:
concurrency:
group:
- ${{ github.repository }}-${{ github.event.number || github.head_ref ||
- github.sha }}-${{ github.workflow }}-${{ github.event_name ==
- 'pull_request_review_comment' && 'pr_comment' || 'pr' }}
+ ${{ github.repository }}-${{ github.event.pull_request.number || github.run_id }}-${{ github.workflow }}
cancel-in-progress: ${{ github.event_name != 'pull_request_review_comment' }}This change uses github.event.pull_request.number which is available in both pull_request and pull_request_review_comment events. If that's not available (for example, in case of a workflow_dispatch event), it falls back to github.run_id which is unique for each run. This ensures that all jobs related to the same PR will be grouped together, regardless of the event type.
There was a problem hiding this comment.
Files selected (1)
- .github/workflows/ai-pr-reviewer.yml (1)
Review comments generated (1)
- Review: 0
- LGTM: 1
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected (1)
- .github/workflows/ai-pr-reviewer.yml (1)
Review comments generated (1)
- Review: 0
- LGTM: 1
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Issue
変更内容
(変更した内容を記載してください)
確認方法
(確認方法を記載してください)
Screenshot (任意)
Summary by CodeRabbit