datatables: Fix priority of default converters #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some scenarios default converters would be used when a defined converter was available. This was caused by returning a default converter as soon as no regular converter was available. This heuristic works well with two exceptions: * When the table contains a single line the default table entry transformer is never applicable * When the table keys don't imply a table entry the default table entry transformer is never applicable By inlining this lookup and working out the exceptions the old behaviour is restored. Fixes: cucumber/cucumber-jvm#1489 Fixes: cucumber/cucumber-jvm#1490
mpkorstanje
force-pushed
the
fix-default-converter-priority
branch
from
e0fd74e
to
be42d30
Compare
mpkorstanje
force-pushed
the
fix-default-converter-priority
branch
from
9dd0eec
to
fb1a238
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some scenarios default converters would be used when a defined
converter was available. This was caused by returning a default
converter as soon as no regular converter was available.
This heuristic works well with two exceptions:
transformer is never applicable
entry transformer is never applicable
By inlining this lookup and working out the exceptions the
old behaviour is restored.
Details
Fixes: cucumber/cucumber-jvm#1489
Fixes: cucumber/cucumber-jvm#1490
Types of changes
Checklist: