Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluator: use toposort by default #2892

Closed
myitcv opened this issue Feb 29, 2024 · 3 comments
Closed

evaluator: use toposort by default #2892

myitcv opened this issue Feb 29, 2024 · 3 comments

Comments

@myitcv
Copy link
Member

myitcv commented Feb 29, 2024

This is a tracking issue that captures the need for us to specify the order of fields during evaluation. This is a necessary part of work on the new evaluator.

spec: need to specify iteration order of struct comprehension · #474 is one aspect of the detail of this issue.

@mvdan
Copy link
Member

mvdan commented Dec 26, 2024

@cuematthew @mpvl I believe we forgot to update this issue with CUE_EXPERIMENT=toposort (#3558), as I understand that we are resolving this issue in the implementation by providing toposort as the new default and documented field ordering. In my opinion, we should be able to mark this issue as resolved once the default is flipped - and toposort is documented for end users at a high level.

#474 then still tracks updating the spec with any of this, if we wish to.

@mvdan mvdan changed the title evaluator: specifying the order of fields evaluator: use toposort by default Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Release v0.12 Jan 8, 2025
@mvdan mvdan moved this from Backlog to v0.12.0-alpha.2 in Release v0.12 Jan 8, 2025
@mvdan
Copy link
Member

mvdan commented Jan 8, 2025

After a brief chat with @myitcv, we agreed to repurpose this issue to track enabling the experiment by default, but otherwise we agree that this is pretty much done with Matthew's work.

@mvdan
Copy link
Member

mvdan commented Jan 22, 2025

@cuematthew resolved this in https://review.gerrithub.io/c/cue-lang/cue/+/1207475, but we failed to link to this issue via a "Fixes". Closing as resolved now.

@mvdan mvdan closed this as completed Jan 22, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Evaluator Roadmap Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: v0.12.0-alpha.2
Development

No branches or pull requests

2 participants