Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update txtpbfmt dependency #3475

Closed
wants to merge 1 commit into from
Closed

Update txtpbfmt dependency #3475

wants to merge 1 commit into from

Conversation

TvdW
Copy link
Contributor

@TvdW TvdW commented Oct 3, 2024

The API on this dependency changed, so let's update the code and move on. This allows the cue Go api to be used together with other code that pulls in the updated dependency.

The API on this dependency changed, so let's update the code and move
on.

Signed-off-by: Tom van der Woerdt <info@tvdw.eu>
@TvdW TvdW requested a review from cueckoo as a code owner October 3, 2024 10:47
Copy link
Member

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvdan
Copy link
Member

mvdan commented Oct 4, 2024

Importing to Gerrit as https://review.gerrithub.io/c/cue-lang/cue/+/1202171

@mvdan mvdan self-assigned this Oct 4, 2024
@cueckoo cueckoo closed this in 4330d60 Oct 7, 2024
vanhtuan0409 pushed a commit to anduintransaction/cue that referenced this pull request Oct 15, 2024
The API changed in a backwards incompatible way,
so we need to update to ensure compatibility with other modules
sharing the same dependency.

Closes cue-lang#3475 as merged as of commit 60c9301.

Signed-off-by: Tom van der Woerdt <info@tvdw.eu>
Change-Id: Ieb60adf19acc04b950ff1b7fb0a303d1be15552b
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1202171
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants