From 9e0a5ffc3667e1ca0e53144de1e7d55997917df2 Mon Sep 17 00:00:00 2001 From: James Telfer <792299+jamestelfer@users.noreply.github.com> Date: Fri, 15 Mar 2024 22:17:03 +1100 Subject: [PATCH] fix: tweak output alignment The padding on the bottom element pulled the text out of line. Adding the check mark makes the annotation a little clearer that it's all OK. --- src/report/annotation.gohtml | 4 ++-- src/report/testdata/TestReports/findings_included.golden | 2 +- src/report/testdata/TestReports/image_label.golden | 4 ++-- .../testdata/TestReports/multi-platform_findings.golden | 2 +- src/report/testdata/TestReports/no_vulnerabilities.golden | 4 ++-- src/report/testdata/TestReports/some_findings_ignored.golden | 2 +- src/report/testdata/TestReports/sorted_findings.golden | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/report/annotation.gohtml b/src/report/annotation.gohtml index b633fc84..5b6e3199 100644 --- a/src/report/annotation.gohtml +++ b/src/report/annotation.gohtml @@ -37,7 +37,7 @@ be wrapped in

tag by the Markdown renderer in Buildkite. {{ end }} {{ else }} -

No vulnerabilities reported.

+

✅ No vulnerabilities reported.

{{ end }} {{ if .FindingSummary.FailedPlatforms }}
@@ -124,7 +124,7 @@ be wrapped in

tag by the Markdown renderer in Buildkite.

{{ end }} -

+

scan completed: {{ .FindingSummary.ImageScanCompletedAt | timeAgo }} | source updated: {{ .FindingSummary.VulnerabilitySourceUpdatedAt | timeAgo }}

diff --git a/src/report/testdata/TestReports/findings_included.golden b/src/report/testdata/TestReports/findings_included.golden index 80825778..d5a4bc0e 100644 --- a/src/report/testdata/TestReports/findings_included.golden +++ b/src/report/testdata/TestReports/findings_included.golden @@ -101,7 +101,7 @@ -

+

scan completed: | source updated:

diff --git a/src/report/testdata/TestReports/image_label.golden b/src/report/testdata/TestReports/image_label.golden index de516bcb..9d70f99d 100644 --- a/src/report/testdata/TestReports/image_label.golden +++ b/src/report/testdata/TestReports/image_label.golden @@ -7,7 +7,7 @@

test-repo@digest-value

-

No vulnerabilities reported.

+

✅ No vulnerabilities reported.

@@ -20,7 +20,7 @@ -

+

scan completed: | source updated:

diff --git a/src/report/testdata/TestReports/multi-platform_findings.golden b/src/report/testdata/TestReports/multi-platform_findings.golden index f8cef614..64f4f325 100644 --- a/src/report/testdata/TestReports/multi-platform_findings.golden +++ b/src/report/testdata/TestReports/multi-platform_findings.golden @@ -78,7 +78,7 @@ -

+

scan completed: | source updated:

diff --git a/src/report/testdata/TestReports/no_vulnerabilities.golden b/src/report/testdata/TestReports/no_vulnerabilities.golden index 7c810337..564fabeb 100644 --- a/src/report/testdata/TestReports/no_vulnerabilities.golden +++ b/src/report/testdata/TestReports/no_vulnerabilities.golden @@ -6,7 +6,7 @@

Vulnerability summary for "test-repo@digest-value"

-

No vulnerabilities reported.

+

✅ No vulnerabilities reported.

@@ -19,7 +19,7 @@ -

+

scan completed: | source updated:

diff --git a/src/report/testdata/TestReports/some_findings_ignored.golden b/src/report/testdata/TestReports/some_findings_ignored.golden index 19be4128..6c123dab 100644 --- a/src/report/testdata/TestReports/some_findings_ignored.golden +++ b/src/report/testdata/TestReports/some_findings_ignored.golden @@ -134,7 +134,7 @@ Ignored to give the base image a chance to be updated -

+

scan completed: | source updated:

diff --git a/src/report/testdata/TestReports/sorted_findings.golden b/src/report/testdata/TestReports/sorted_findings.golden index ca935ed6..e086aecc 100644 --- a/src/report/testdata/TestReports/sorted_findings.golden +++ b/src/report/testdata/TestReports/sorted_findings.golden @@ -141,7 +141,7 @@ -

+

scan completed: | source updated: