From d41c3250fe534ad501c514b8c32394194adff87e Mon Sep 17 00:00:00 2001 From: Andreas Arvidsson Date: Tue, 22 Apr 2025 11:18:04 +0200 Subject: [PATCH 1/3] Use latest stable vscode for windows CI tests --- packages/test-harness/src/launchVscodeAndRunTests.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/test-harness/src/launchVscodeAndRunTests.ts b/packages/test-harness/src/launchVscodeAndRunTests.ts index ad2442788d..ff88a2ef21 100644 --- a/packages/test-harness/src/launchVscodeAndRunTests.ts +++ b/packages/test-harness/src/launchVscodeAndRunTests.ts @@ -36,14 +36,7 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) { // we don't have to update the branch protection rules every time we bump // the legacy VSCode version. - // NB: Because of a CI crashing issue the vscode version is pinned. - // https://github.com/cursorless-dev/cursorless/issues/2878 - - const vscodeVersion = useLegacyVscode - ? "1.82.0" - : os.platform() === "win32" - ? "stable" - : "1.97.2"; + const vscodeVersion = useLegacyVscode ? "1.82.0" : "stable"; const vscodeExecutablePath = await downloadAndUnzipVSCode(vscodeVersion); const [cli, ...args] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath); From e8c3f168ffbda495e0094fe7040a86d6fc2d2d9e Mon Sep 17 00:00:00 2001 From: Andreas Arvidsson Date: Tue, 22 Apr 2025 11:25:50 +0200 Subject: [PATCH 2/3] pin all platforms --- packages/test-harness/src/launchVscodeAndRunTests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/test-harness/src/launchVscodeAndRunTests.ts b/packages/test-harness/src/launchVscodeAndRunTests.ts index ff88a2ef21..b96a2c7b1d 100644 --- a/packages/test-harness/src/launchVscodeAndRunTests.ts +++ b/packages/test-harness/src/launchVscodeAndRunTests.ts @@ -36,7 +36,7 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) { // we don't have to update the branch protection rules every time we bump // the legacy VSCode version. - const vscodeVersion = useLegacyVscode ? "1.82.0" : "stable"; + const vscodeVersion = useLegacyVscode ? "1.82.0" : "1.97.2"; const vscodeExecutablePath = await downloadAndUnzipVSCode(vscodeVersion); const [cli, ...args] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath); From 3a110a2b838bff805903f9ca106eb74c9c37bfa7 Mon Sep 17 00:00:00 2001 From: Andreas Arvidsson Date: Tue, 22 Apr 2025 11:32:52 +0200 Subject: [PATCH 3/3] Restore comment --- packages/test-harness/src/launchVscodeAndRunTests.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/test-harness/src/launchVscodeAndRunTests.ts b/packages/test-harness/src/launchVscodeAndRunTests.ts index b96a2c7b1d..b38e39f4b2 100644 --- a/packages/test-harness/src/launchVscodeAndRunTests.ts +++ b/packages/test-harness/src/launchVscodeAndRunTests.ts @@ -36,6 +36,9 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) { // we don't have to update the branch protection rules every time we bump // the legacy VSCode version. + // NB: Because of a CI crashing issue the vscode version is pinned. + // https://github.com/cursorless-dev/cursorless/issues/2878 + const vscodeVersion = useLegacyVscode ? "1.82.0" : "1.97.2"; const vscodeExecutablePath = await downloadAndUnzipVSCode(vscodeVersion); const [cli, ...args] =