Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sort options as a parameter #65

Open
joel16 opened this issue Sep 25, 2019 · 2 comments
Open

Multiple sort options as a parameter #65

joel16 opened this issue Sep 25, 2019 · 2 comments

Comments

@joel16
Copy link

joel16 commented Sep 25, 2019

Hi, I was wondering if there's a possibility to have tinydir_open_sorted to have multiple sorting options. One way I can think of to achieve this would be to pass our own (comparator?) like this one https://github.com/cxong/tinydir/blob/master/tinydir.h#L755

This would allow the user to sort alphabetically in both ascending/descending order as well sorting by size, timestamps etc.

@cxong
Copy link
Owner

cxong commented Sep 25, 2019

I prefer keeping compatibility, which means we could add a new function like tinydir_open_custom which can take in a comparator.

To maintain forward compatibility, we could define an options struct, which just has the comparator for now, but could have more fields in the future.

As a workaround for now, you could perform your own qsort on dir._files.

@joel16
Copy link
Author

joel16 commented Sep 26, 2019

Thanks for your response, I may as well go with your workaround for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants