Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of photo of the day #1

Open
si-the-pie opened this issue Dec 24, 2020 · 4 comments
Open

Location of photo of the day #1

si-the-pie opened this issue Dec 24, 2020 · 4 comments

Comments

@si-the-pie
Copy link
Member

si-the-pie commented Dec 24, 2020

Photo

BF5CB22A-9613-4C26-B41A-1264ED822DEC
Scene on following this photo of the day link:
https://twitter.com/cyclestreets/status/1342017166267314178?s=21

Map

3A81C72D-027F-4D23-99C2-815EE4081B42
Closing the overlay shows map around current location, not County Down where the photo is located .

Where is it?

One reason users follow Photo of the day from Twitter, or follow a photo map location link more generally is to determine where the image is located.

Suggestion

Turn off “use current location mode” when following location link, allowing user to close overlay and explore area of photo.

@mvl22
Copy link
Member

mvl22 commented Dec 24, 2020

Yes, this is missing a map centring upon popup, with a disabling of the current location just before that.

This will require a fix in the apiCallId handling part of the layerviewer library, which we trigger as a result of this declaration:
https://github.com/cyclestreets/mobile-design/blob/master/js/cyclestreets.js#L315-L324

@mvl22
Copy link
Member

mvl22 commented Jan 22, 2021

The fix is basically to add at
https://github.com/cyclestreets/Mapboxgljs.LayerViewer/blob/master/src/layerviewer.js#L2342

  • Disable geolocation
  • Move map to the lat/lon in features[0]

@si-the-pie
Copy link
Member Author

It occurs to me that during the add photo procedure using the mobileweb one of the screens shows the location of the photo alreay - when prompting to add details. In the screenshot I've scrolled the marker into view. So could this screen be re-purposed in some way?

IMG_FE8BF40FF7F8-1

https://cambridge.cyclestreets.net/location/162426/

@mvl22
Copy link
Member

mvl22 commented Feb 3, 2021

No, that would need a lot of changes. Don’t forget the flip side of the pop up too.

Digging into that UI would still require the same fix, which is identified above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants