Skip to content

Commit

Permalink
Merge pull request #253 from hjoliver/rem-vis-section
Browse files Browse the repository at this point in the history
Remove obsoletion flow.cylc visualization section.
  • Loading branch information
wxtim authored Jul 5, 2021
2 parents 3015dd1 + 23c190c commit 2a8a726
Show file tree
Hide file tree
Showing 10 changed files with 6 additions and 77 deletions.
2 changes: 0 additions & 2 deletions src/user-guide/writing-workflows/configuration.rst
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,6 @@ several top level section headings:
- workflow-wide defaults in the *root* namespace
- a nested family hierarchy with common properties
inherited by related tasks
:cylc:conf:`[visualization]`
Workflow graph styling

.. _Validation:

Expand Down
8 changes: 4 additions & 4 deletions src/user-guide/writing-workflows/runtime.rst
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ from the root namespace:
Workflow Visualization And Multiple Inheritance
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The first parent inherited by a namespace is also used as the
collapsible family group when visualizing the workflow. If this is not what
you want, you can demote the first parent for visualization purposes,
without affecting the order of inheritance of runtime properties:
The first parent a namespace inherits from doubles as the collapsible family
group in workflow UI views and visualization. If this is not what you want, you
can demote the first parent for visualization purposes, without affecting the
order of inheritance of runtime properties:

.. code-block:: cylc
Expand Down
14 changes: 0 additions & 14 deletions src/user-guide/writing-workflows/scheduling.rst
Original file line number Diff line number Diff line change
Expand Up @@ -651,14 +651,6 @@ For example, we can write our workflow like so, to produce the graph as shown:
R1/T12 = "prep[^] => baz"
T00 = "foo[-P1D] => foo => bar"
T12 = "baz[-P1D] => baz => qux"
[visualization]
initial cycle point = 20130808T00
final cycle point = 20130810T00
[[node attributes]]
foo = "color=red"
bar = "color=orange"
baz = "color=green"
qux = "color=blue"
.. container:: image

Expand Down Expand Up @@ -705,12 +697,6 @@ the initial cycle point) and then repeat every ``PT6H`` (6 hours):
foo[-PT6H] => foo
foo => bar
"""
[visualization]
initial cycle point = 20130808T00
final cycle point = 20130808T18
[[node attributes]]
foo = "color=red"
bar = "color=orange"
.. container:: image

Expand Down
6 changes: 2 additions & 4 deletions src/workflow-design-guide/efficiency.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@ The Task Family Hierarchy

A properly designed family hierarchy fulfils three purposes in Cylc:

- efficient sharing of all configuration common to groups of related
tasks
- efficient sharing of configuration common to groups of related tasks
- efficient bulk triggering, for clear scheduling graphs
- clean workflow visualization and monitoring, because families are
collapsible
- collapsible families in workflow visualization and UI views


.. _Sharing By Inheritance:
Expand Down
2 changes: 0 additions & 2 deletions src/workflows/empy/cities/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,3 @@ CLEANUP = True
inherit = @CITY
@[ end for ]
@[ end for ]

@empy.include("./workflow-visualization.cylc")
9 changes: 0 additions & 9 deletions src/workflows/empy/cities/workflow-visualization.cylc

This file was deleted.

21 changes: 0 additions & 21 deletions src/workflows/inherit/multi/one/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,3 @@

[[var_p1, var_p2]]
inherit = VAR, PARALLEL

[visualization]
# NOTE ON VISUALIZATION AND MULTIPLE INHERITANCE: overlapping
# family groups can have overlapping attributes, so long as
# non-conflicting attributes are used to style each group. Below,
# for example, OPS tasks are filled green and SERIAL tasks are
# outlined blue, so that ops_s1 and ops_s2 are green with a blue
# outline. But if the SERIAL tasks are explicitly styled as "not
# filled" (by setting "style=") this will override the fill setting
# in the (previously defined and therefore lower precedence) OPS
# group, making ops_s1 and ops_s2 unfilled with a blue outline.
# Alternatively you can just create a manual node group for ops_s1
# and ops_s2 and style them separately.
[[node groups]]
#(see comment above:)
#serial_ops = ops_s1, ops_s2
[[node attributes]]
OPS = "style=filled", "fillcolor=green"
SERIAL = "color=blue" #(see comment above:), "style="
#(see comment above:)
#serial_ops = "color=blue", "style=filled", "fillcolor=green"
3 changes: 0 additions & 3 deletions src/workflows/inherit/single/two/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,3 @@
inherit = OPS
[[[meta]]]
description = "OPS ATOVS postprocessing"

[visualization]
collapsed families = OPS, VAR, BAZ
9 changes: 0 additions & 9 deletions src/workflows/jinja2/cities/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,3 @@
inherit = {{ CITY }}
{% endfor %}
{% endfor %}

[visualization]
initial cycle point = 2011-08-08T12
final cycle point = 2011-08-08T23
[[node groups]]
cleaning = clean, cleanup
[[node attributes]]
cleaning = 'style=filled', 'fillcolor=yellow'
NewYork = 'style=filled', 'fillcolor=lightblue'
9 changes: 0 additions & 9 deletions src/workflows/satellite/ext-trigger/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,3 @@ rm -rf $CYLC_WORKFLOW_SHARE_DIR $CYLC_WORKFLOW_WORK_DIR
"""
[[[meta]]]
title = collate all products from the workflow run

[visualization]
default node attributes = "style=filled", "shape=box"
[[node attributes]]
satsim = "fillcolor=yellow"
WORKDIR = "fillcolor=limegreen"
get_data = "fillcolor=skyblue"
products = "fillcolor=orange"
collate = "fillcolor=red"

0 comments on commit 2a8a726

Please sign in to comment.