more response to review

cylc · Sep 12, 2023 · 6a4dd3b · 6a4dd3b
1 parent caa068a
commit 6a4dd3b
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/cylc/flow/task_job_mgr.py b/cylc/flow/task_job_mgr.py
@@ -261,12 +261,13 @@ def submit_task_jobs(self, workflow, itasks, curve_auth,
 
         Return (list): list of tasks that attempted submission.
         """
-
         if is_simulation:
             return self._simulation_submit_task_jobs(itasks, workflow)
+
         # Prepare tasks for job submission
         prepared_tasks, bad_tasks = self.prep_submit_task_jobs(
             workflow, itasks)
+
         # Reset consumed host selection results
         self.task_remote_mgr.subshell_eval_reset()
 
@@ -999,6 +1000,7 @@ def _simulation_submit_task_jobs(self, itasks, workflow):
         for itask in itasks:
             itask.waiting_on_job_prep = False
             itask.submit_num += 1
+            itask.state_reset(TASK_STATUS_PREPARING)
             self._set_retry_timers(itask)
 
             # We largely want a clean "platform" and not localhost,
@@ -1016,11 +1018,6 @@ def _simulation_submit_task_jobs(self, itasks, workflow):
             itask.jobs.append(
                 self.get_simulation_job_conf(itask, workflow)
             )
-
-            # Set status from waiting to preparing to prevent
-            # _process_message_check returning false because
-            # state is waiting.
-            itask.state.status = 'preparing'
             self.task_events_mgr.process_message(
                 itask, INFO, TASK_OUTPUT_SUBMITTED,
             )