incorrect prerequisites after task state changes

[hjoliver]

Since cylc-6.10.1 [UPDATE: this is where the first part of the problem started; more below]

First revealed here: #2561 (comment)

[hjoliver]

git bisect says the offending commit is 3b654e9

[hjoliver]

Some change in that commit results in prerequisites.set_satisfied() being called when a task is ready to run [UPDATE: oops, see next comment] fails

Revising the title - prerequisite status remains correct unless/until a task fails (the task in my test suite was set to fail immediately).

[hjoliver]

The plot thickens. On master, the situation is worse than as described in the previous comment. All prerequisites are set satisfied when the task is ready to run (or thereabouts) ... or are least listed that way by cylc show. I suspect this results from using "forced task state reset" semantics (where it may? be OK to artificially mess with prerequisite status) for normal in-run state changes.

[hjoliver]

Test case. Observe baz prerequisites and outputs with watch -n 1 cylc show SUITE baz.1.

[scheduling]
    [[dependencies]]
        graph = FOO:succeed-any & BAR:finish-all => baz
[runtime]
    [[FOO, BAR]]
        pre-script = sleep $(( 10 + RANDOM % 10 ))
    [[foo_1, foo_2, foo_3, foo_4]]
        inherit = FOO
    [[foo_4]]
        script = false
    [[bar_1, bar_2, bar_3, bar_4]]
        inherit = BAR
    [[bar_4]]
        script = false
    [[baz]]
        init-script = sleep 5  # stay 'submitted' for 5 sec

Once baz.1 finishes (leave watch ... running) try manually forcing its state, and retriggering it. Remove one upstream family from the live suite to confirm that prerequisites get unset on reset to 'waiting':

[hjoliver]

New PR to come, after rethinking how to handle outputs and prerequisites properly on state changes.