Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra log files: remove legacy #5610

Closed
oliver-sanders opened this issue Jul 3, 2023 · 0 comments · Fixed by #5672
Closed

extra log files: remove legacy #5610

oliver-sanders opened this issue Jul 3, 2023 · 0 comments · Fixed by #5672
Assignees
@oliver-sanders
Labels
small
Milestone
8.3.0

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Jul 3, 2023 •
edited
Loading

The extra log files configuration used to be used to allow the GUI to open job log files other than the standard job.out, job.err, etc.

For Cylc 8 we've taken a different approach, the cat-log command now lists the available files from the file system so the GUI can always see all log files without the need for them to be explicitly listed.

However, there is a little bit of legacy code left over:

  • The logfiles key in the job_config.
  • The extra_logs field in ProtoBuf.
  • The extraLogs field in GraphQL.
  • The jobLogNames field in GraphQL (which now just holds the standard job log names?)

All of which are essentially hardcoded to an empty list I think? We should rip this out.

Non-urgent, but as this implies schema changes it may be better to get it out the way sooner, hence the 8.3.0 milestone, but that can slide.
@oliver-sanders oliver-sanders added this to the cylc-8.3.0 milestone Jul 3, 2023
@oliver-sanders oliver-sanders mentioned this issue Jul 3, 2023
Merged
8 tasks
@oliver-sanders oliver-sanders self-assigned this Aug 8, 2023
oliver-sanders added a commit to oliver-sanders/cylc-ui that referenced this issue Aug 8, 2023
@oliver-sanders
graphql: remove extraLogs field
c6b27a0 
* See cylc/cylc-flow#5610
@oliver-sanders oliver-sanders mentioned this issue Aug 8, 2023
Merged
8 tasks
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Aug 8, 2023
@oliver-sanders
graphql: remove extraLogs field
abf2d03 
* Closes cylc#5610
* Remove residual code leftover from the obsolete `extra log files`
  runtime configuration option.
@oliver-sanders oliver-sanders mentioned this issue Aug 8, 2023
Merged
8 tasks
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 11, 2023
@oliver-sanders
graphql: remove extraLogs field
840096b 
* Closes cylc#5610
* Remove residual code leftover from the obsolete `extra log files`
  runtime configuration option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliver-sanders oliver-sanders

Labels
small
Projects
None yet
Milestone
8.3.0
Development

Successfully merging a pull request may close this issue.

extra log files: remove legacy oliver-sanders/cylc-flow
1 participant
@oliver-sanders