Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload and restart - smart insertion of new tasks #774

Closed
arjclark opened this issue Nov 15, 2013 · 8 comments · Fixed by #3515
Closed

reload and restart - smart insertion of new tasks #774

arjclark opened this issue Nov 15, 2013 · 8 comments · Fixed by #3515
Milestone

Comments

@arjclark
Copy link
Contributor

Result of an email conversation between myself, @hjoliver and @dpmatthews.

It would be useful to have cylc perform a smart insertion of new tasks on performing a reload.

Options could include:

  • insert at latest cycle
  • insert at earliest (in focus) cycle
  • an option to specify the cycle at which to perform the insertion

There may be a challenge with determining what to do about purged tasks and whether they are "new", depending on how the suite tracks those operations across reloads.

@ghost ghost assigned hjoliver Nov 15, 2013
@arjclark
Copy link
Contributor Author

@dpmatthews wants to have a think and comment on what the best way to implement this may be.

@arjclark
Copy link
Contributor Author

Missed this one from the email chain as an option:

"another option could be to choose the first instance with upstream dependencies not yet satisfied, or the instance just prior to that - and trigger it immediately in case its upstream dependencies had been cleaned up already." - @hjoliver

@dpmatthews
Copy link
Contributor

I assume the default will remain not to insert new tasks.
First instance with upstream dependencies not yet satisfied sounds like it would be a useful option. Otherwise, insertion at latest cycle would probably deal with most simple cases.
The option to insert new tasks at a specified cycle would be useful to deal with more complex cases, e.g. suites spread over multiple cycles.

@hjoliver
Copy link
Member

Worth doing - some users do seem to find the lack of new task auto-insertion confusing.

@hjoliver hjoliver assigned oliver-sanders and unassigned hjoliver Jun 16, 2016
@hjoliver hjoliver changed the title cylc reload - smart insertion of new tasks on reload reload and restart - smart insertion of new tasks on reload Jun 16, 2016
@hjoliver hjoliver changed the title reload and restart - smart insertion of new tasks on reload reload and restart - smart insertion of new tasks Jun 16, 2016
@hjoliver
Copy link
Member

hjoliver commented Jun 16, 2016

[meeting] we agreed: find earliest instance of an unsatisfied task that depends on a new task, and insert there.

@oliver-sanders
Copy link
Member

[meeting] A robust, reliable solution that works for all edge cases is a major challenge. A solution which fails to handle these edge cases properly risks generating a false sense of security. Once we move to a spawn-on-demmand model for the task pool, auto-insert on reload should become somewhat easier.

@oliver-sanders
Copy link
Member

To be closed with or after #987

@oliver-sanders oliver-sanders removed their assignment Jul 27, 2018
@matthewrmshin matthewrmshin modified the milestones: later, cylc-9 Aug 28, 2019
@dpmatthews dpmatthews modified the milestones: cylc-9, cylc-8.0a3 Jul 29, 2020
@oliver-sanders
Copy link
Member

So very happy to close this, I can finally delete my failed attempts.

@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants