Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SECURITY.md (7.8.x) #3128

Merged
merged 4 commits into from
Apr 26, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,21 @@ all changes see the [closed
milestones](https://github.com/cylc/cylc/milestones?state=closed) for each
release.

-------------------------------------------------------------------------------
## SECURITY NOTE

*[Jinja2 CVE-2019-8341 (High)](https://nvd.nist.gov/vuln/detail/CVE-2019-8341)
An issue was discovered in Jinja2 2.10. The `from_string` function is prone to
Server Side Template Injection (SSTI) where it takes the "source" parameter as
a template object, renders it, and then returns it. The attacker can exploit it
with `{{INJECTION COMMANDS}}` in a URI*

- cylc-7 (7.8.x branch, written in Python 2) has a bundled copy of Jinja2 2.10
that cannot be updated because the new Jinja2 requires Python 3. However **this
CVE does not impact cylc-7 because Cylc workflow definitions are not web
pages**.
- cylc-8 (master branch, written in Python 3) does not bundle Jinja2.
hjoliver marked this conversation as resolved.
Show resolved Hide resolved

-------------------------------------------------------------------------------
## __cylc-7.8.1 (2019-01-25)__

Expand Down
32 changes: 9 additions & 23 deletions SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,27 @@ project.
* [Reporting a Bug](#reporting-a-bug)
* [Disclosure Policy](#disclosure-policy)
* [Comments on this Policy](#comments-on-this-policy)
* [Current Alerts](#current-alerts)

## Reporting a Bug

The Cylc team take security bugs seriously. Thank you for improving the
The Cylc maintainers take security bugs seriously. Thank you for improving the
security of Cylc. We appreciate your efforts and responsible disclosure and
will make every effort to acknowledge your contributions.

Report security bugs by sending an email to the [Cylc
Forum](mailto:cylc@googlegroups.com) or by posting a [Cylc repository
Issue](https://github.com/cylc/cylc-flow/issues). Project maintainers will
endeavor to respond within 48 hours. Progress toward a fix will be recorded on
the Issue page, and resulting new releases will be announced on the mail forum.
Please report security bugs by sending an email to the lead Cylc maintainers,
[Hilary Oliver](mailto:hilary.oliver@niwa.co.nz) and [Matt
Shin](matthew.shin@metoffice.gov.uk). If a fix is needed, progress will be
recorded on Cylc repository Issue page on GitHub, and resulting new releases
will be announced on the Cylc [mail forum](mailto:cylc@googlegroups.com).

Report security bugs in third-party modules to the person or team maintaining
the module.

## Disclosure Policy

When the team receives a security bug report, they will assign it to a primary
handler. This person will coordinate the fix and release process as follows:
When the Cylc maintainers receive a security bug report, they will assign it to
a primary handler. This person will coordinate the fix and release process as
follows:

* Confirm the problem and determine the affected versions.
* Audit code to find any potential similar problems.
Expand All @@ -37,17 +37,3 @@ handler. This person will coordinate the fix and release process as follows:

If you have suggestions on how this process could be improved please submit a
pull request.

## Current Alerts

*[Jinja2 CVE-2019-8341 (High)](https://nvd.nist.gov/vuln/detail/CVE-2019-8341)
An issue was discovered in Jinja2 2.10. The `from_string` function is prone to
Server Side Template Injection (SSTI) where it takes the "source" parameter as
a template object, renders it, and then returns it. The attacker can exploit it
with `{{INJECTION COMMANDS}}` in a URI*

- cylc-7 (7.8.x branch, written in Python 2) has a bundled copy of Jinja2 2.10
that cannot be updated because the new Jinja2 requires Python 3. However **this
CVE does not impact cylc-7 because Cylc workflow definitions are not web
pages**.
- cylc-8 (master branch, written in Python 3) does not bundle Jinja2.