Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play: upgrade --start-task's specified in legacy format #4925

Merged
merged 1 commit into from
Jun 23, 2022
Merged

play: upgrade --start-task's specified in legacy format #4925

merged 1 commit into from
Jun 23, 2022

Conversation

oliver-sanders
Copy link
Member

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Does not need tests (why?).
  • No change log entry required (why? minor edge case of little concern)
  • No documentation update required.

@oliver-sanders oliver-sanders added small could be better Not exactly a bug, but not ideal. labels Jun 22, 2022
@oliver-sanders oliver-sanders added this to the cylc-8.0rc4 milestone Jun 22, 2022
@oliver-sanders oliver-sanders requested a review from MetRonnie June 22, 2022 12:50
@oliver-sanders oliver-sanders self-assigned this Jun 22, 2022
@oliver-sanders
play: upgrade --start-task's specified in legacy format
b5bda3f 
* Extend CLI upgrading to the Cylc 8 --start-task option.
* Closes cylc#4920
hjoliver
hjoliver approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested as working 👍

@MetRonnie MetRonnie merged commit 4a1ed03 into cylc:master Jun 23, 2022
@oliver-sanders oliver-sanders deleted the 4920 branch June 23, 2022 07:51
wxtim added a commit to wxtim/cylc that referenced this pull request Jul 4, 2022
@wxtim
Merge branch 'master' into cylc-linter.bk
8dec7ca 
* master: (30 commits)
  Log dir tidy (cylc#4836)
  Cut down on back-compat warnings, plus other tidying (cylc#4943)
  Validate platform settings (background job runner) (cylc#4938)
  clean: push error message to stderr
  Update cylc/flow/id_match.py
  Fix unintended directory stripping during cylc install (cylc#4931)
  stop cylc validate swallowing useful errors (cylc#4936)
  Improve config reference docs (cylc#4916)
  glblcfg: increase default rolling archive length
  Fix job state with pre-submitted failure
  Update tests/functional/cylc-reinstall/02-failures.t
  reinstall: require workflow ID argument
  play: upgrade --start-task's specified in legacy format (cylc#4925)
  expand schema docstring internally (cylc#4926)
  Added a new task filtering test.
  Add comment [skip ci]
  Fix optparse Options class for std options (cylc#4919)
  uid: warn if the run number is provided as a cycle
  Tweak prev.
  Fix task filtering.
  ...
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Milestone
cylc-8.0.0
Development

Successfully merging this pull request may close these issues.

Start task does not accept legacy <task>.<point> format
3 participants
@oliver-sanders @hjoliver @MetRonnie