Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions: exclude mypy with more recent python version #5735

Merged
merged 1 commit into from
Sep 19, 2023
Merged

actions: exclude mypy with more recent python version #5735

merged 1 commit into from
Sep 19, 2023

Conversation

oliver-sanders
Copy link
Member

  • matplotlib has not dropped Python 3.7 support.
  • mypy produces a false positive error when scanning the installed matplotlib code (even though no_silence_site_packages=false).
  • cylc is still compatible with the more recent matplotlib releases, it's down to the installer (pip/conda/whatever) to install a version that's compatible with the python interpretter so there's no reason to put an upper pin in the metadata.

@oliver-sanders
actions: exclude mypy with more recent python version
ccde837 
* matplotlib has not dropped Python 3.7 support.
* mypy produces a false positive error when scanning the installed
  matplotlib code (even though no_silence_site_packages=false).
* cylc is still compatible with the more recent matplotlib releases,
  it's down to the installer (pip/conda/whatever) to install a
  version that's compatible with the python interpretter
  so there's no reason to put an upper pin in the metadata.
@oliver-sanders oliver-sanders added this to the cylc-8.2.2 milestone Sep 19, 2023
@oliver-sanders oliver-sanders self-assigned this Sep 19, 2023
@oliver-sanders
Copy link
Member Author

oliver-sanders commented Sep 19, 2023 •
edited
Loading

Checked that mypy is being run for linux/py3.9

Created an issue for the 3.10+ compatibility issue: #5736

@oliver-sanders oliver-sanders mentioned this pull request Sep 19, 2023
Open
@oliver-sanders oliver-sanders merged commit 6157644 into cylc:8.2.x Sep 19, 2023
9 checks passed
@oliver-sanders oliver-sanders deleted the mypy-matplotlib branch September 19, 2023 16:10
@hjoliver hjoliver mentioned this pull request Sep 20, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgrahamdawson markgrahamdawson markgrahamdawson approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver-sanders @markgrahamdawson